chore: audit components

crates/core/tests/combobox_bench.rs

@@ -1,6 +1,5 @@
 use std::cell::RefCell;
 use std::rc::Rc;
-use std::time::Instant;
 
 use gpui::{
     AppContext as _, Context, Entity, IntoElement, ParentElement as _, Render, SharedString,
@@ -70,19 +69,31 @@ fn real_keystrokes_are_not_pathologically_slow() {
         window.draw(cx).clear(cx);
     });
 
-    let started = Instant::now();
+    // The focused caret must ride executor timers, never frame requests.
+    let frames = visual.update(|window, cx| window.simulate_next_frame(cx));
+    assert_eq!(
+        frames, 0,
+        "an idle focused combobox must not request animation frames"
+    );
+
     for letter in "abcdefghijklmnopqrstuvwxyz".chars() {
         visual.simulate_keystrokes(&letter.to_string());
         visual.update(|window, cx| {
             window.draw(cx).clear(cx);
         });
     }
-    let elapsed = started.elapsed();
 
     let total_renders = *renders.borrow();
     println!(
-        "26 real keystrokes: {elapsed:?}, host renders: {total_renders} ({} per keystroke)",
+        "26 real keystrokes: {total_renders} host renders ({:.2} per keystroke)",
         total_renders as f32 / 26.
     );
-    assert!(elapsed.as_millis() < 2000, "typing took {elapsed:?}");
+    assert!(
+        total_renders >= 26,
+        "every keystroke must redraw the page; got {total_renders} renders"
+    );
+    assert!(
+        total_renders <= 26 * 3,
+        "typing caused {total_renders} host renders; healthy filtering stays under 3 per keystroke"
+    );
 }