chore: audit all components (#2)

Reviewed-on: #2

crates/core/src/select.rs

@@ -6,7 +6,8 @@ use gpui::{
     SharedString, StatefulInteractiveElement as _, StyleRefinement, Styled as _, Window,
 };
 use gpui_native_icons::{IconRole, icon};
-use gpui_native_theme::{ActiveTheme as _, Size};
+use gpui_native_theme::{ActiveTheme as _, BORDER_WIDTH, Size};
+use gpui_native_utils::focus_ring;
 
 use crate::common::{Sizable, StyledExt, h_flex};
 use crate::menu::{Menu, MenuItem};
@@ -169,6 +170,8 @@ where
         let muted_foreground = theme.colors.muted_foreground;
         let radius = theme.radius.control;
         let icon_size = metrics.dense_icon_size;
+        let fields_bordered = theme.borders.fields;
+        let focus_ring_on = theme.borders.focus_ring;
 
         let label = self
             .a11y_label
@@ -180,7 +183,22 @@ where
                 .use_keyed_state("select-open", cx, |_, _| false)
                 .clone()
         });
+
         let is_open = *open.read(cx);
+        let open_for_items = open.clone();
+
+        let (rest_border, hover_border) = if fields_bordered {
+            (
+                if is_open && !focus_ring_on {
+                    ring
+                } else {
+                    border
+                },
+                border,
+            )
+        } else {
+            (input, muted)
+        };
 
         let selected_index = self.selected.as_ref().and_then(|value| {
             self.options
@@ -194,6 +212,7 @@ where
         let trigger_id = self.id.clone();
         let trigger_label = label.clone();
         let trigger_style = self.style;
+
         let trigger = move |_window: &mut Window, _cx: &mut App| {
             let text = trigger_selected
                 .as_ref()
@@ -207,17 +226,18 @@ where
 
             h_flex()
                 .id((trigger_id.clone(), "select-trigger"))
+                .debug_selector(|| "select-trigger".to_string())
                 .role(Role::ComboBox)
                 .aria_label(trigger_label.clone())
                 .cursor_pointer()
                 .justify_between()
                 .gap_2()
                 .w_full()
-                .h(metrics.input_height)
+                .h(metrics.input_height + BORDER_WIDTH * 2.0)
                 .px(metrics.dense_padding_x)
                 .rounded(radius)
                 .border_1()
-                .border_color(if is_open { ring } else { border })
+                .border_color(rest_border)
                 .bg(input)
                 .text_size(metrics.text_size)
                 .text_color(if trigger_selected.is_some() {
@@ -225,7 +245,10 @@ where
                 } else {
                     muted_foreground
                 })
-                .hover(|style| style.bg(muted))
+                .when(is_open && focus_ring_on, |trigger| {
+                    trigger.shadow(focus_ring(ring))
+                })
+                .hover(|style| style.bg(muted).border_color(hover_border))
                 .child(text)
                 .child(
                     icon(IconRole::ChevronDown)
@@ -236,7 +259,6 @@ where
                 .into_any_element()
         };
 
-        let open_for_items = open.clone();
         let items = move |_window: &mut Window, _cx: &mut App| {
             self.options
                 .iter()