chore: audit all components (#2)

Reviewed-on: #2

crates/core/tests/field_bench.rs

@@ -1,7 +1,3 @@
-use std::cell::RefCell;
-use std::rc::Rc;
-use std::time::Instant;
-
 use gpui::{
     AppContext as _, Context, Entity, IntoElement, ParentElement as _, Render, SharedString,
     Styled as _, TestAppContext, VisualTestContext, Window, div,
@@ -13,12 +9,10 @@ use gpui_native_core::input::{Input, InputState};
 
 struct FieldHost {
     url: Entity<InputState>,
-    renders: Rc<RefCell<usize>>,
 }
 
 impl Render for FieldHost {
     fn render(&mut self, _window: &mut Window, cx: &mut Context<Self>) -> impl IntoElement {
-        *self.renders.borrow_mut() += 1;
         let url_error = self
             .url
             .read(cx)
@@ -38,76 +32,48 @@ impl Render for FieldHost {
     }
 }
 
-/// A field page in a real window, with the url input focused.
-fn field_host() -> (
-    TestAppContext,
-    Entity<InputState>,
-    Rc<RefCell<usize>>,
-    VisualTestContext,
-) {
+/// A field page in a real window; the url input is focused unless
+/// `focus` is false, which leaves the page truly idle.
+fn field_host(focus: bool) -> (TestAppContext, Entity<InputState>, VisualTestContext) {
     let cx = TestAppContext::single();
     cx.update(init);
-    let (url, renders, window) = cx.update(|cx| {
-        let renders = Rc::new(RefCell::new(0));
+    let (url, window) = cx.update(|cx| {
         let url = InputState::new(cx);
         let url_for_host = url.clone();
-        let renders_for_host = renders.clone();
         let window = cx
             .open_window(gpui::WindowOptions::default(), |_, cx| {
-                cx.new(|_| FieldHost {
-                    url: url_for_host,
-                    renders: renders_for_host,
-                })
+                cx.new(|_| FieldHost { url: url_for_host })
             })
             .unwrap();
-        (url, renders, window)
+        (url, window)
     });
     let mut visual = VisualTestContext::from_window(window.into(), &cx);
     visual.update(|window, cx| {
-        let focus = url.read(cx).focus_handle();
-        window.focus(&focus, cx);
+        if focus {
+            let focus = url.read(cx).focus_handle();
+            window.focus(&focus, cx);
+        }
         window.draw(cx).clear(cx);
     });
-    (cx, url, renders, visual)
-}
-
-fn draw(visual: &mut VisualTestContext) {
-    visual.update(|window, cx| {
-        window.draw(cx).clear(cx);
-    });
-}
-
-fn type_and_time(visual: &mut VisualTestContext, text: &str) -> std::time::Duration {
-    let started = Instant::now();
-    for letter in text.chars() {
-        visual.simulate_keystrokes(&letter.to_string());
-        draw(visual);
-    }
-    let elapsed = started.elapsed();
-    println!(
-        "{} keystrokes: {elapsed:?} ({:.2} ms per keystroke)",
-        text.chars().count(),
-        elapsed.as_secs_f64() / text.chars().count() as f64 * 1000.
-    );
-    elapsed
+    (cx, url, visual)
 }
 
 #[test]
 fn an_idle_field_page_schedules_no_frames() {
-    let (_cx, _url, _renders, mut visual) = field_host();
+    let (_cx, _url, mut visual) = field_host(false);
     let frames = visual.update(|window, cx| window.simulate_next_frame(cx));
     assert_eq!(
         frames, 0,
-        "an idle field page must not request animation frames"
+        "an idle unfocused field page must not request animation frames"
     );
 }
 
 #[test]
-fn field_typing_frame_cost() {
-    let (_cx, _url, _renders, mut visual) = field_host();
-    let elapsed = type_and_time(&mut visual, "dsdsadsadadadada");
+fn a_focused_field_page_schedules_frames_for_its_blink() {
+    let (_cx, _url, mut visual) = field_host(true);
+    let frames = visual.update(|window, cx| window.simulate_next_frame(cx));
     assert!(
-        elapsed.as_millis() < 1000,
-        "typing 16 characters took {elapsed:?}"
+        frames > 0,
+        "the focused caret's blink needs frames to redraw at the blink cadence"
     );
 }