Move layout metrics into theme and apply audit cleanups

crates/core/src/command_palette.rs

@@ -7,10 +7,10 @@ use gpui::{
     AnyElement, App, Context, ElementId, Entity, InteractiveElement as _, IntoElement, KeyBinding,
     MouseButton, ParentElement as _, Render, Role, ScrollHandle, SharedString,
     StatefulInteractiveElement as _, Styled as _, Subscription, Window, actions, canvas, deferred,
-    div, px, relative,
+    div, relative,
 };
 use gpui_native_icons::{IconRole, icon};
-use gpui_native_theme::{ActiveTheme as _, Size};
+use gpui_native_theme::{ActiveTheme as _, POPUP_MAX_HEIGHT, Size};
 
 use crate::common::{h_flex, v_flex};
 use crate::input::{Input, InputState, InputStateEvent};
@@ -333,7 +333,7 @@ impl Render for CommandPaletteState {
                 let row_ix = row;
 
                 h_flex()
-                    .id(("command", row))
+                    .id((ElementId::from(command.id.clone()), "command"))
                     .debug_selector({
                         let id = id.clone();
                         move || format!("{id}-command-{row}")
@@ -401,7 +401,7 @@ impl Render for CommandPaletteState {
             ScrollArea::new((id.clone(), "rows"))
                 .handle(scroll.read(cx).clone())
                 .axes(ScrollAxes::Vertical)
-                .max_h(px(320.))
+                .max_h(POPUP_MAX_HEIGHT)
                 .children(rows)
                 .into_any_element()
         };