From faa81af9ebd0b010d3fc3a45dd53a4c0c305c3e0 Mon Sep 17 00:00:00 2001 From: Ren Amamiya Date: Wed, 11 Nov 2026 20:04:35 +0700 Subject: [PATCH] core: remove sizing from badge --- crates/core/src/badge.rs | 12 ++---------- examples/gallery/src/main.rs | 4 +--- 2 files changed, 3 insertions(+), 13 deletions(-) diff --git a/crates/core/src/badge.rs b/crates/core/src/badge.rs index 658d670..f8c2298 100644 --- a/crates/core/src/badge.rs +++ b/crates/core/src/badge.rs @@ -9,7 +9,7 @@ use gpui::{ use gpui_native_icons::Icon; use gpui_native_theme::{ActiveTheme as _, Size, Theme}; -use crate::common::{Sizable, StyledExt, h_flex}; +use crate::common::{StyledExt, h_flex}; /// The tooltip view builder gpui's `.tooltip(...)` expects. type TooltipBuilder = Rc AnyView>; @@ -77,7 +77,6 @@ pub struct Badge { label: SharedString, icon: Option, variant: BadgeVariant, - size: Size, tooltip: Option, style: StyleRefinement, } @@ -94,7 +93,6 @@ impl Badge { label: label.into(), icon: None, variant: BadgeVariant::default(), - size: Size::default(), tooltip: None, style: StyleRefinement::default(), } @@ -125,12 +123,6 @@ impl Badge { } } -impl Sizable for Badge { - fn apply_size(&mut self, size: Size) { - self.size = size; - } -} - impl gpui::Styled for Badge { fn style(&mut self) -> &mut gpui::StyleRefinement { &mut self.style @@ -140,7 +132,7 @@ impl gpui::Styled for Badge { impl RenderOnce for Badge { fn render(self, _window: &mut Window, cx: &mut App) -> impl IntoElement { let theme = cx.theme(); - let metrics = theme.sizes.resolve(self.size); + let metrics = theme.sizes.resolve(Size::Small); let label_size = metrics.caption_size; let (background, foreground, border) = self.variant.tokens(theme); diff --git a/examples/gallery/src/main.rs b/examples/gallery/src/main.rs index ca0dc03..a3d5635 100644 --- a/examples/gallery/src/main.rs +++ b/examples/gallery/src/main.rs @@ -1903,9 +1903,7 @@ impl Render for BadgeDemo { ) .child(Badge::new("badge-drift", "drift").variant(BadgeVariant::Warning)) .child(Badge::new("badge-danger", "12").variant(BadgeVariant::Danger)) - .child(Badge::new("badge-outline", "outline").variant(BadgeVariant::Outline)) - .child(Badge::new("badge-small", "small").small()) - .child(Badge::new("badge-large", "large").large()), + .child(Badge::new("badge-outline", "outline").variant(BadgeVariant::Outline)), )) .child(demo_section( "tooltip",