reya/nostr-connect
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: convert the stored hex key to bytes before nip44 getConversationKey #1

Merged
reya merged 1 commits from chad.curtis/fix-nip44-hex-key AGit into master 2026-10-16 00:37:12 +00:00
Conversation 1 Commits 1 Files Changed 2
+29 -4
chad.curtis commented 2026-10-15 20:00:36 +00:00
Contributor
Copy Link
Copy Source

Since 1.0.0 every window.nostr.nip44.encrypt/decrypt call fails with expected Uint8Array, got type=string, which breaks NIP-17 DMs and anything else using NIP-44 on sites that use the extension.

private_key is stored as hex, and nostr-tools 2.23 (noble-curves v2) no longer accepts hex strings in getConversationKey. signEvent and getPublicKey already convert with hexToBytes(sk); this does the same in getSharedSecret.

Also adds NIP-44 tests (hex key rejected, converted key round-trips with a peer) in place of the note saying NIP-44 was only covered by the build. vitest run passes (50 tests), biome is clean, and a build.js prod firefox bundle encrypts where the published 1.0.0 throws.

Since 1.0.0 every `window.nostr.nip44.encrypt`/`decrypt` call fails with `expected Uint8Array, got type=string`, which breaks NIP-17 DMs and anything else using NIP-44 on sites that use the extension. `private_key` is stored as hex, and nostr-tools 2.23 (noble-curves v2) no longer accepts hex strings in `getConversationKey`. `signEvent` and `getPublicKey` already convert with `hexToBytes(sk)`; this does the same in `getSharedSecret`. Also adds NIP-44 tests (hex key rejected, converted key round-trips with a peer) in place of the note saying NIP-44 was only covered by the build. `vitest run` passes (50 tests), biome is clean, and a `build.js prod firefox` bundle encrypts where the published 1.0.0 throws.
chad.curtis added 1 commit 2026-10-15 20:00:36 +00:00
fix: convert the stored hex key to bytes before nip44 getConversationKey db6dad218e 
nostr-tools 2.23 (noble-curves v2) no longer accepts hex strings, so every nip44.encrypt/decrypt failed with "expected Uint8Array, got type=string". Adds nip44 tests.
reya merged commit 67d6e26093 into master 2026-10-16 00:37:12 +00:00
reya commented 2026-10-16 00:37:24 +00:00
Owner
Copy Link
Copy Source

thank for your contributation

thank for your contributation
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
reya (Ren Amamiya)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: reya/nostr-connect#1