clean up

crates/workspace/src/views/repo_detail/about.rs

@@ -30,8 +30,9 @@ fn announcement_rows(announcement: &Announcement, cx: &App) -> AnyElement {
         text(
             announcement
                 .name
-                .clone()
-                .unwrap_or_else(|| SharedString::from("—")),
+                .as_deref()
+                .map(SharedString::from)
+                .unwrap_or_else(|| SharedString::from("-")),
         ),
         cx,
     ));
@@ -41,8 +42,9 @@ fn announcement_rows(announcement: &Announcement, cx: &App) -> AnyElement {
         text(
             announcement
                 .description
-                .clone()
-                .unwrap_or_else(|| SharedString::from("—")),
+                .as_deref()
+                .map(SharedString::from)
+                .unwrap_or_else(|| SharedString::from("-")),
         ),
         cx,
     ));
@@ -131,7 +133,12 @@ fn row(label: &'static str, value: AnyElement, cx: &App) -> AnyElement {
 }
 
 /// Plain text value, wrapping within the dialog.
-fn text(value: SharedString) -> AnyElement {
+fn text<T>(value: T) -> AnyElement
+where
+    T: Into<SharedString>,
+{
+    let value = value.into();
+
     div()
         .text_sm()
         .w_full()

crates/workspace/src/views/repo_detail/browser.rs

@@ -143,7 +143,7 @@ impl RepoDetailView {
                         self.code_element(path.as_ref(), cx)
                     }
                 }
-                Some(FileContent::Binary) => placeholder("Binary file — preview not supported", cx),
+                Some(FileContent::Binary) => placeholder("Binary file - preview not supported", cx),
                 Some(FileContent::TooLarge) => placeholder("File is too large to preview", cx),
                 Some(FileContent::Failed(message)) => placeholder(message, cx),
                 None => preview_spinner(),

crates/workspace/src/views/repo_detail/mod.rs

@@ -1342,7 +1342,8 @@ impl RepoDetailView {
             .map(|announcement| {
                 announcement
                     .name
-                    .clone()
+                    .as_deref()
+                    .map(SharedString::from)
                     .unwrap_or_else(|| SharedString::from(announcement.id.clone()))
             })
             .unwrap_or_default()
@@ -2359,13 +2360,14 @@ fn fork_row(announcement: &Announcement, cx: &mut Context<RepoDetailView>) -> Op
                 .find(|a| a.addr() == *addr)
                 .map(|a| {
                     a.name
-                        .clone()
+                        .as_deref()
+                        .map(SharedString::from)
                         .unwrap_or_else(|| SharedString::from(a.id.clone()))
                 })
                 .unwrap_or_else(|| SharedString::from(addr.identifier.clone()));
             (SharedString::from(format!("Forked from {name}")), true)
         }
-        None => (upstream.display(), false),
+        None => (SharedString::from(upstream.display().as_str()), false),
     };
 
     let row = h_flex()

crates/workspace/src/views/repo_detail/new_pull_request.rs

@@ -140,7 +140,8 @@ fn fork_candidates<'a>(
 fn fork_display_name(announcement: &Announcement) -> SharedString {
     announcement
         .name
-        .clone()
+        .as_deref()
+        .map(SharedString::from)
         .unwrap_or_else(|| SharedString::from(announcement.id.clone()))
 }
 

crates/workspace/src/views/repo_list.rs

@@ -187,12 +187,14 @@ impl RepoListView {
 
         let name = announcement
             .name
-            .clone()
-            .unwrap_or_else(|| SharedString::from(announcement.id.clone()));
+            .as_deref()
+            .map(SharedString::from)
+            .unwrap_or(SharedString::from(announcement.id.clone()));
 
         let description = announcement
             .description
-            .clone()
+            .as_deref()
+            .map(SharedString::from)
             .unwrap_or(SharedString::from("No description"));
 
         let activity = last_activity
@@ -213,7 +215,8 @@ impl RepoListView {
                     .find(|a| a.addr() == *addr)
                     .map(|a| {
                         a.name
-                            .clone()
+                            .as_deref()
+                            .map(SharedString::from)
                             .unwrap_or_else(|| SharedString::from(a.id.clone()))
                     })
                     .unwrap_or_else(|| SharedString::from(addr.identifier.clone()));

crates/workspace/src/views/sidebar/mod.rs

@@ -347,7 +347,8 @@ impl SidebarPanel {
     ) -> impl IntoElement {
         let name = announcement
             .name
-            .clone()
+            .as_deref()
+            .map(SharedString::from)
             .unwrap_or_else(|| SharedString::from(announcement.id.clone()));
         let avatar = PixelAvatar::new(format!("{}:{}", announcement.owner, announcement.id));