clean up

docs/over-engineering-cleanup-plan.md

@@ -145,11 +145,14 @@ renderer when the extent is `px(0.)`, and wraps the renderer's output in
 `dock_frame`. `dock_extent` is `px(0.)` exactly when `!open && !is_bottom`, which
 is precisely the condition of the early return here.
 
-- [ ] Delete the `if !open && !placement.is_bottom() { return div(); }` guard.
-- [ ] Stop re-applying `.flex().flex_none().relative().overflow_hidden()` and the
-      per-placement width/height; base already applies them.
-- [ ] Keep the closed-bottom strip height override, but confirm against base's
-      `CLOSED_BOTTOM_STRIP` that the intended height is `TAB_BAR_HEIGHT`.
+- [x] Delete the `if !open && !placement.is_bottom() { return div(); }` guard.
+- [x] Stop re-applying the box. The chrome is now `.flex().size_full().relative()`,
+      the same shape the pinned reference skin (`crates/ui/src/dock/dock.rs`) uses;
+      base's `dock_frame` supplies the extent and the overflow clip.
+- [x] Keep the closed-bottom strip height override. Note: base's `dock_frame`
+      hard-codes `CLOSED_BOTTOM_STRIP` (29px) with `overflow_hidden`, so the
+      `TAB_BAR_HEIGHT` (44px) override is clipped and has no visible effect. The
+      strip is 29px today; changing it needs an upstream change.
 - [ ] Smoke test: open and close left, bottom, and right docks; check widths,
       the bottom strip height, and resize handles.
 
@@ -157,7 +160,7 @@ is precisely the condition of the early return here.
 
 File: `crates/signed_state/src/backend.rs`
 
-- [ ] Delete the `if refs.is_empty() { return outcome; }` guard.
+- [x] Delete the `if refs.is_empty() { return outcome; }` guard.
 
 All three call sites pass a non-empty `refs`: one passes a literal one-element
 vec, one is inside `if !refs.is_empty()`, one is the `else` of that check.
@@ -169,19 +172,19 @@ File: `crates/workspace/src/views/inbox.rs`
 The backend pump already coalesces relay bursts into one `NostrUpdate`, and
 `query_inbox` reads only the local database.
 
-- [ ] Delete the `REFRESH_DEBOUNCE` constant.
-- [ ] In `refresh`, drop the spawned timer; call `run_refresh` directly after
+- [x] Delete the `REFRESH_DEBOUNCE` constant.
+- [x] In `refresh`, drop the spawned timer; call `run_refresh` directly after
       `refresh.request()` returns `Schedule`, matching `RepoStore::refresh`.
-- [ ] Keep `RefreshGate` for fold/overlap.
+- [x] Keep `RefreshGate` for fold/overlap.
 - [ ] Smoke test: inbox updates live as relay events land, with no added delay.
 
 ### 2.4 `DockPlacement::Center` arms in `dock_toggle_button` (optional)
 
 File: `crates/dock/src/tab_panel.rs`
 
-- [ ] The only call sites pass `Left`, `Bottom`, `Right`. Collapse the `Center`
-      arms to `unreachable!()` or restructure so the match is exhaustive without
-      a dead branch.
+- [x] The only call sites pass `Left`, `Bottom`, `Right`. The `designated`
+      match's `Center` arm now returns early instead of yielding a dead `None`;
+      the icon match keeps `Center => return None` for exhaustiveness.
 
 Low value; skip if it makes the match less readable.