feat: app settings (#11)

Reviewed-on: https://git.reya.su/reya/signed/pulls/11

crates/workspace/Cargo.toml

@@ -8,6 +8,7 @@ publish.workspace = true
 assets = { path = "../assets" }
 dock = { workspace = true }
 paths = { path = "../paths" }
+settings = { path = "../settings" }
 signed_core = { path = "../signed_core" }
 signed_git = { path = "../signed_git" }
 signed_state = { path = "../signed_state" }

crates/workspace/src/views/repo_detail/init_dialog.rs

@@ -10,6 +10,7 @@ use gpui_component::dialog::{DialogDescription, DialogFooter, DialogHeader, Dial
 use gpui_component::form::{field, v_form};
 use gpui_component::input::{Input, InputState, Textarea};
 use gpui_component::{ActiveTheme, Disableable, WindowExt};
+use settings::SettingsStore;
 use signed_state::Backend;
 
 use super::RepoDetailView;
@@ -49,7 +50,12 @@ pub fn open(
         InputState::new(window, cx).placeholder("wss://relay.example.com or relay.example.com")
     });
     let state = cx.new(|_| InitRepoState::default());
-    let grasp_state = cx.new(|_| GraspServersState::new_default());
+    let grasp_settings = SettingsStore::global(cx)
+        .read(cx)
+        .settings()
+        .grasp_servers
+        .clone();
+    let grasp_state = cx.new(|_| GraspServersState::new_default(&grasp_settings));
 
     load_user_grasp_servers(grasp_state.clone(), window, cx);
 

crates/workspace/src/views/sidebar/create_repo_dialog.rs

@@ -7,6 +7,7 @@ use gpui_component::dialog::{DialogDescription, DialogFooter, DialogHeader, Dial
 use gpui_component::form::{field, v_form};
 use gpui_component::input::{Input, InputState, Textarea};
 use gpui_component::{ActiveTheme, Disableable, IconName, WindowExt, h_flex};
+use settings::SettingsStore;
 use signed_core::Announcement;
 use signed_state::Backend;
 
@@ -26,6 +27,15 @@ pub struct CreateRepoState {
 /// list) and falls back to the shared defaults when none are set. On
 /// success the dialog closes and the new repository opens in the dock.
 pub fn open(dock_area: WeakEntity<DockArea>, window: &mut Window, cx: &mut App) {
+    let settings = SettingsStore::global(cx);
+    let default_folder = settings
+        .read(cx)
+        .settings()
+        .create_repository
+        .default_folder
+        .clone()
+        .unwrap_or_else(paths::desktop_dir);
+
     let name_input = cx.new(|cx| InputState::new(window, cx).placeholder("Repository name"));
     let desc_input = cx.new(|cx| {
         TextareaState::new(window, cx)
@@ -33,20 +43,20 @@ pub fn open(dock_area: WeakEntity<DockArea>, window: &mut Window, cx: &mut App)
             .placeholder("Short description")
     });
     let folder_input = cx.new(|cx| {
-        InputState::new(window, cx)
-            .default_value(paths::desktop_dir().to_string_lossy().to_string())
+        InputState::new(window, cx).default_value(default_folder.to_string_lossy().to_string())
     });
     let relay_input = cx.new(|cx| {
         InputState::new(window, cx).placeholder("wss://relay.example.com or relay.example.com")
     });
     let state = cx.new(|_| CreateRepoState::default());
-    let grasp_state = cx.new(|_| GraspServersState::new_default());
+    let grasp_settings = settings.read(cx).settings().grasp_servers.clone();
+    let grasp_state = cx.new(|_| GraspServersState::new_default(&grasp_settings));
 
     load_user_grasp_servers(grasp_state.clone(), window, cx);
 
     window.open_dialog(cx, move |dialog, _window, _cx| {
         const DESC: &str = "Publish a new repository to your grasp servers.";
-        const FOLDER_NOTE: &str = "Where the repository is stored, defaults to your Desktop";
+        const FOLDER_NOTE: &str = "Where the repository is stored.";
 
         let name_input = name_input.clone();
         let desc_input = desc_input.clone();
@@ -148,10 +158,12 @@ pub fn open(dock_area: WeakEntity<DockArea>, window: &mut Window, cx: &mut App)
 
 /// Prompt the user to pick the folder the repository will be stored in, using
 /// the platform's native folder picker, and show the result in the disabled
-/// folder input.
+/// folder input. The picked folder is remembered in the settings so it
+/// becomes the default next time.
 fn choose_folder(folder_input: &Entity<InputState>, window: &mut Window, cx: &mut App) {
     let handle = window.window_handle();
     let folder_input = folder_input.clone();
+    let store = SettingsStore::global(cx);
 
     let prompt = cx.prompt_for_paths(PathPromptOptions {
         files: false,
@@ -166,6 +178,14 @@ fn choose_folder(folder_input: &Entity<InputState>, window: &mut Window, cx: &mu
         {
             let path = path.to_string_lossy().to_string();
             cx.update_window(handle, |_, window, cx| {
+                store.update(cx, |store, cx| {
+                    store.edit(
+                        |settings| {
+                            settings.create_repository.default_folder = Some(path.clone().into())
+                        },
+                        cx,
+                    );
+                });
                 folder_input.update(cx, |input, cx| input.set_value(path, window, cx));
             })
             .ok();

crates/workspace/src/views/sidebar/grasp_servers.rs

@@ -5,16 +5,10 @@ use gpui_component::form::{Field, field};
 use gpui_component::input::{Input, InputState};
 use gpui_component::{ActiveTheme, IconName, Sizable, h_flex, v_flex};
 use nostr::prelude::*;
+use settings::{DEFAULT_GRASP_SERVERS, GraspServersSettings};
 use signed_core::filters;
 use signed_state::Backend;
 
-/// Grasp servers offered when the user hasn't published a grasp list (kind `10317`) yet.
-const DEFAULT_GRASP_SERVERS: [&str; 3] = [
-    "wss://relay.ngit.dev",
-    "wss://gitnostr.com",
-    "wss://git.shakespeare.diy",
-];
-
 /// State of the grasp-server section of a publish dialog, so async
 /// results can be rendered.
 #[derive(Default)]
@@ -30,11 +24,22 @@ pub struct GraspServersState {
 
 impl GraspServersState {
     /// Defaults until the user's grasp list arrives; replaced by it when it lists any servers.
-    pub fn new_default() -> Self {
+    ///
+    /// The servers come from the persisted settings, falling back to the
+    /// built-in defaults when the configured list is empty.
+    pub fn new_default(settings: &GraspServersSettings) -> Self {
+        let urls: Vec<String> = if settings.default_servers.is_empty() {
+            DEFAULT_GRASP_SERVERS
+                .iter()
+                .map(|url| (*url).to_owned())
+                .collect()
+        } else {
+            settings.default_servers.clone()
+        };
         Self {
             loading_servers: true,
             servers_enabled: false,
-            grasp_servers: DEFAULT_GRASP_SERVERS
+            grasp_servers: urls
                 .iter()
                 .filter_map(|url| RelayUrl::parse(url).ok())
                 .collect(),
@@ -52,8 +57,7 @@ pub fn grasp_servers_field(
     relay_input: &Entity<InputState>,
     cx: &App,
 ) -> Field {
-    const SERVER_NOTE: &str =
-        "Where the repository is hosted, the initial push goes to each server";
+    const SERVER_NOTE: &str = "Where the repository is hosted";
 
     let state = state.clone();
     let relay_input = relay_input.clone();

crates/workspace/src/views/sidebar/mod.rs

@@ -26,6 +26,7 @@ pub(crate) mod grasp_servers;
 mod import_dialog;
 mod onboarding_dialog;
 pub(crate) mod passphrase_dialog;
+mod settings_dialog;
 
 use self::onboarding_dialog::OnboardingState;
 
@@ -591,9 +592,9 @@ impl Render for SidebarPanel {
                             "Settings",
                             Icon::new(IconName::Settings).small(),
                         )
-                        .on_click(
-                            cx.listener(|this, _ev, window, cx| this.open_explore(window, cx)),
-                        ),
+                        .on_click(cx.listener(|_, _ev, window, cx| {
+                            settings_dialog::open(window, cx);
+                        })),
                     ),
             )
     }

crates/workspace/src/views/sidebar/settings_dialog.rs

@@ -0,0 +1,810 @@
+//! The Settings dialog, opened from the sidebar's Settings entry.
+//!
+//! A custom settings layout that divides related settings into sections
+//! separated by simple horizontal lines — no `GroupBox` boxes and no settings
+//! navigation sidebar. Every control edits the persisted [`SettingsStore`]
+//! and applies the change to the live theme immediately.
+
+use std::cell::Cell;
+use std::path::PathBuf;
+use std::rc::Rc;
+
+use gpui::prelude::*;
+use gpui::{
+    AnyWindowHandle, App, Entity, PathPromptOptions, SharedString, Subscription, Window, div, px,
+};
+use gpui_component::button::{Button, ButtonVariants};
+use gpui_component::input::{
+    Input, InputEvent, InputState, NumberInput, NumberInputEvent, StepAction,
+};
+use gpui_component::select::{Select, SelectEvent, SelectState};
+use gpui_component::separator::Separator;
+use gpui_component::setting::NumberFieldOptions;
+use gpui_component::switch::Switch;
+use gpui_component::{
+    ActiveTheme, IconName, IndexPath, Sizable, Theme, ThemeMode, ThemeRegistry, WindowExt, h_flex,
+    v_flex,
+};
+use nostr::prelude::RelayUrl;
+use settings::{AppearanceMode, Settings, SettingsStore};
+use signed_ui::{SelectOption, setting_block, setting_row};
+
+/// The index of `value` in `options`, for seeding a [`SelectState`].
+fn selected_index(options: &[SelectOption], value: &str) -> Option<IndexPath> {
+    options
+        .iter()
+        .position(|option| option.value().as_ref() == value)
+        .map(|row| IndexPath::default().row(row))
+}
+
+/// The light and dark themes registered in the theme registry.
+fn theme_options(cx: &App) -> (Vec<SelectOption>, Vec<SelectOption>) {
+    let registry = ThemeRegistry::global(cx);
+    let mut light = Vec::new();
+    let mut dark = Vec::new();
+    for config in registry.themes().values() {
+        let name = config.name.clone();
+        if config.mode.is_dark() {
+            dark.push(SelectOption::new(name.clone(), name));
+        } else {
+            light.push(SelectOption::new(name.clone(), name));
+        }
+    }
+    light.sort_by(|a, b| a.label().as_ref().cmp(b.label().as_ref()));
+    dark.sort_by(|a, b| a.label().as_ref().cmp(b.label().as_ref()));
+    (light, dark)
+}
+
+/// Stateful controls of the settings dialog, created once when it opens so
+/// their values survive re-renders of the dialog content.
+struct SettingsControls {
+    appearance: Entity<SelectState<Vec<SelectOption>>>,
+    light_theme: Entity<SelectState<Vec<SelectOption>>>,
+    dark_theme: Entity<SelectState<Vec<SelectOption>>>,
+    font_size: Entity<InputState>,
+    mono_font_size: Entity<InputState>,
+    radius: Entity<InputState>,
+    radius_lg: Entity<InputState>,
+    grasp_server_input: Entity<InputState>,
+    /// The effective default create-repository folder, shown in the disabled
+    /// folder selector.
+    default_folder: Entity<InputState>,
+    /// Keeps the control subscriptions alive for the dialog's lifetime.
+    _subscriptions: Vec<Subscription>,
+}
+
+impl SettingsControls {
+    fn new(window: &mut Window, cx: &mut App) -> Self {
+        let store = SettingsStore::global(cx);
+        let settings = store.read(cx).settings().clone();
+
+        let appearance_options = vec![
+            SelectOption::new("system", "System"),
+            SelectOption::new("light", "Light"),
+            SelectOption::new("dark", "Dark"),
+        ];
+        let appearance_value = match settings.appearance {
+            AppearanceMode::System => "system",
+            AppearanceMode::Light => "light",
+            AppearanceMode::Dark => "dark",
+        };
+        let appearance = cx.new(|cx| {
+            SelectState::new(
+                appearance_options.clone(),
+                selected_index(&appearance_options, appearance_value),
+                window,
+                cx,
+            )
+        });
+
+        let (light_options, dark_options) = theme_options(cx);
+        let light_theme = cx.new(|cx| {
+            SelectState::new(
+                light_options.clone(),
+                selected_index(&light_options, &settings.theme.light_theme),
+                window,
+                cx,
+            )
+        });
+        let dark_theme = cx.new(|cx| {
+            SelectState::new(
+                dark_options.clone(),
+                selected_index(&dark_options, &settings.theme.dark_theme),
+                window,
+                cx,
+            )
+        });
+
+        let font_size = cx.new(|cx| {
+            InputState::new(window, cx).default_value(settings.theme.font_size.to_string())
+        });
+        let mono_font_size = cx.new(|cx| {
+            InputState::new(window, cx).default_value(settings.theme.mono_font_size.to_string())
+        });
+        let radius = cx
+            .new(|cx| InputState::new(window, cx).default_value(settings.theme.radius.to_string()));
+        let radius_lg = cx.new(|cx| {
+            InputState::new(window, cx).default_value(settings.theme.radius_lg.to_string())
+        });
+
+        let grasp_server_input =
+            cx.new(|cx| InputState::new(window, cx).placeholder("wss://relay.example.com"));
+        let default_folder = cx.new(|cx| {
+            let folder = settings
+                .create_repository
+                .default_folder
+                .clone()
+                .unwrap_or_else(paths::desktop_dir);
+            InputState::new(window, cx).default_value(folder.to_string_lossy().to_string())
+        });
+
+        let mut subscriptions = Vec::new();
+
+        subscriptions.push(cx.subscribe(&appearance, |_, event, cx| {
+            if let SelectEvent::Confirm(Some(value)) = event {
+                let appearance = match value.as_ref() {
+                    "light" => AppearanceMode::Light,
+                    "dark" => AppearanceMode::Dark,
+                    _ => AppearanceMode::System,
+                };
+                let store = SettingsStore::global(cx);
+                store.update(cx, |store, cx| {
+                    store.edit(|settings| settings.appearance = appearance, cx);
+                });
+                apply_appearance(appearance, cx);
+            }
+        }));
+
+        subscriptions.push(cx.subscribe(&light_theme, |_, event, cx| {
+            if let SelectEvent::Confirm(Some(value)) = event {
+                let store = SettingsStore::global(cx);
+                store.update(cx, |store, cx| {
+                    store.edit(
+                        |settings| settings.theme.light_theme = value.to_string(),
+                        cx,
+                    );
+                });
+                apply_theme(cx);
+            }
+        }));
+
+        subscriptions.push(cx.subscribe(&dark_theme, |_, event, cx| {
+            if let SelectEvent::Confirm(Some(value)) = event {
+                let store = SettingsStore::global(cx);
+                store.update(cx, |store, cx| {
+                    store.edit(|settings| settings.theme.dark_theme = value.to_string(), cx);
+                });
+                apply_theme(cx);
+            }
+        }));
+
+        wire_number_input(
+            &font_size,
+            &mut subscriptions,
+            window.window_handle(),
+            cx,
+            NumberFieldOptions {
+                min: 10.,
+                max: 32.,
+                ..Default::default()
+            },
+            settings.theme.font_size as f64,
+            |value, cx| {
+                let store = SettingsStore::global(cx);
+                store.update(cx, |store, cx| {
+                    store.edit(|settings| settings.theme.font_size = value as f32, cx);
+                });
+                apply_theme(cx);
+            },
+        );
+
+        wire_number_input(
+            &mono_font_size,
+            &mut subscriptions,
+            window.window_handle(),
+            cx,
+            NumberFieldOptions {
+                min: 8.,
+                max: 32.,
+                ..Default::default()
+            },
+            settings.theme.mono_font_size as f64,
+            |value, cx| {
+                let store = SettingsStore::global(cx);
+                store.update(cx, |store, cx| {
+                    store.edit(|settings| settings.theme.mono_font_size = value as f32, cx);
+                });
+                apply_theme(cx);
+            },
+        );
+
+        wire_number_input(
+            &radius,
+            &mut subscriptions,
+            window.window_handle(),
+            cx,
+            NumberFieldOptions {
+                min: 0.,
+                max: 24.,
+                ..Default::default()
+            },
+            settings.theme.radius as f64,
+            |value, cx| {
+                let store = SettingsStore::global(cx);
+                store.update(cx, |store, cx| {
+                    store.edit(|settings| settings.theme.radius = value as f32, cx);
+                });
+                apply_theme(cx);
+            },
+        );
+
+        wire_number_input(
+            &radius_lg,
+            &mut subscriptions,
+            window.window_handle(),
+            cx,
+            NumberFieldOptions {
+                min: 0.,
+                max: 24.,
+                ..Default::default()
+            },
+            settings.theme.radius_lg as f64,
+            |value, cx| {
+                let store = SettingsStore::global(cx);
+                store.update(cx, |store, cx| {
+                    store.edit(|settings| settings.theme.radius_lg = value as f32, cx);
+                });
+                apply_theme(cx);
+            },
+        );
+
+        Self {
+            appearance,
+            light_theme,
+            dark_theme,
+            font_size,
+            mono_font_size,
+            radius,
+            radius_lg,
+            grasp_server_input,
+            default_folder,
+            _subscriptions: subscriptions,
+        }
+    }
+}
+
+/// Open the Settings dialog.
+pub fn open(window: &mut Window, cx: &mut App) {
+    let controls = Rc::new(SettingsControls::new(window, cx));
+    let store = SettingsStore::global(cx);
+    let window_handle = window.window_handle();
+    let store_subscription = cx.observe(&store, move |_, cx| {
+        window_handle
+            .update(cx, |_, window, _| window.refresh())
+            .ok();
+    });
+
+    let dialog_state = Rc::new((controls, store_subscription));
+
+    window.open_dialog(cx, move |dialog, _window, cx| {
+        let dialog_state = dialog_state.clone();
+        dialog
+            .title("Settings")
+            .width(px(650.))
+            .h(px(560.))
+            .child(settings_view(&dialog_state.0, cx))
+    });
+}
+
+/// The settings content: one section per related setting, divided by
+/// horizontal separator lines.
+fn settings_view(controls: &SettingsControls, cx: &mut App) -> impl IntoElement {
+    let store = SettingsStore::global(cx);
+    let settings = store.read(cx).settings().clone();
+
+    v_flex()
+        .mt_2()
+        .gap_4()
+        .w_full()
+        .child(appearance_section(controls, cx))
+        .child(Separator::horizontal())
+        .child(theme_section(&settings, controls, cx))
+        .child(Separator::horizontal())
+        .child(grasp_servers_section(&settings, controls, cx))
+        .child(Separator::horizontal())
+        .child(repositories_section(&settings, controls, cx))
+}
+
+/// How the app picks its appearance.
+fn appearance_section(controls: &SettingsControls, cx: &App) -> impl IntoElement {
+    v_flex().w_full().gap_3().child(setting_row(
+        cx,
+        "Appearance",
+        "Choose whether the app follows the system theme or uses a light/dark theme.",
+        Select::new(&controls.appearance).w_full(),
+    ))
+}
+
+/// Theme configuration: the theme names in the registry plus
+/// the visual tweaks the application customizes at startup.
+fn theme_section(settings: &Settings, controls: &SettingsControls, cx: &App) -> impl IntoElement {
+    v_flex()
+        .gap_3()
+        .w_full()
+        .child(setting_row(
+            cx,
+            "Light Theme",
+            "The theme to use when the appearance is light.",
+            Select::new(&controls.light_theme).w_full(),
+        ))
+        .child(setting_row(
+            cx,
+            "Dark Theme",
+            "The theme to use when the appearance is dark.",
+            Select::new(&controls.dark_theme).w_full(),
+        ))
+        .child(setting_row(
+            cx,
+            "UI Font Size",
+            "Font size for the UI.",
+            NumberInput::new(&controls.font_size).w_full(),
+        ))
+        .child(setting_row(
+            cx,
+            "Editor Font Size",
+            "Font size for editor text.",
+            NumberInput::new(&controls.mono_font_size).w_full(),
+        ))
+        .child(setting_row(
+            cx,
+            "Corner Radius",
+            "The corner radius for UI elements.",
+            NumberInput::new(&controls.radius).w_full(),
+        ))
+        .child(setting_row(
+            cx,
+            "Large Corner Radius",
+            "The corner radius for large UI elements (dialogs, notifications).",
+            NumberInput::new(&controls.radius_lg).w_full(),
+        ))
+        .child(setting_row(
+            cx,
+            "Focus Ring",
+            "Draw a ring around focused controls.",
+            Switch::new("focus-ring")
+                .checked(settings.theme.focus_ring)
+                .on_click(move |checked: &bool, _window, cx| {
+                    let store = SettingsStore::global(cx);
+                    store.update(cx, |store, cx| {
+                        store.edit(|settings| settings.theme.focus_ring = *checked, cx);
+                    });
+                    apply_theme(cx);
+                }),
+        ))
+        .child(setting_row(
+            cx,
+            "Shadows",
+            "The shadow effect for UI elements.",
+            Switch::new("shadows")
+                .checked(settings.theme.shadow)
+                .on_click(move |checked: &bool, _window, cx| {
+                    let store = SettingsStore::global(cx);
+                    store.update(cx, |store, cx| {
+                        store.edit(|settings| settings.theme.shadow = *checked, cx);
+                    });
+                    apply_theme(cx);
+                }),
+        ))
+}
+
+/// The default grasp servers offered when the user hasn't published a grasp list (kind `10317`) yet.
+fn grasp_servers_section(
+    settings: &Settings,
+    controls: &SettingsControls,
+    cx: &App,
+) -> impl IntoElement {
+    let servers = settings.grasp_servers.default_servers.clone();
+
+    v_flex().w_full().gap_3().child(setting_block(
+        cx,
+        "Grasp Servers",
+        "Servers used to host your git repositories via the Grasp protocol",
+        grasp_server_editor(&servers, controls, cx),
+    ))
+}
+
+/// The editable list of default grasp servers plus an add-relay input,
+/// styled like the grasp-server section of the publish dialogs.
+fn grasp_server_editor(
+    servers: &[String],
+    controls: &SettingsControls,
+    cx: &App,
+) -> impl IntoElement {
+    let server_input = controls.grasp_server_input.clone();
+
+    v_flex()
+        .w_full()
+        .gap_2()
+        .children(servers.iter().enumerate().map(|(ix, server)| {
+            h_flex()
+                .w_full()
+                .gap_1()
+                .items_center()
+                .child(
+                    h_flex()
+                        .h_8()
+                        .w_full()
+                        .px_2()
+                        .bg(cx.theme().muted)
+                        .text_color(cx.theme().muted_foreground)
+                        .text_sm()
+                        .rounded(cx.theme().radius)
+                        .child(display_server(server)),
+                )
+                .child(
+                    Button::new(format!("settings-remove-server:{ix}"))
+                        .icon(IconName::Close)
+                        .ghost()
+                        .flex_shrink_0()
+                        .tooltip("Remove")
+                        .on_click(move |_event, _window, cx| {
+                            let store = SettingsStore::global(cx);
+                            store.update(cx, |store, cx| {
+                                store.edit(
+                                    |settings| {
+                                        settings.grasp_servers.default_servers.remove(ix);
+                                    },
+                                    cx,
+                                );
+                            });
+                        }),
+                )
+        }))
+        .child(
+            h_flex()
+                .gap_1()
+                .items_center()
+                .child(div().flex_1().child(Input::new(&server_input)))
+                .child(
+                    Button::new("settings-add-server")
+                        .icon(IconName::Plus)
+                        .ghost()
+                        .tooltip("Add grasp server")
+                        .on_click({
+                            let server_input = server_input.clone();
+                            move |_event, window, cx| add_server(&server_input, window, cx)
+                        }),
+                ),
+        )
+}
+
+/// The bare host of a grasp server (defaults are entered without a scheme),
+/// matching how the publish dialogs display servers.
+fn display_server(server: &str) -> SharedString {
+    RelayUrl::parse(server)
+        .ok()
+        .and_then(|relay| relay.domain().map(|domain| domain.to_owned()))
+        .map(SharedString::from)
+        .unwrap_or_else(|| SharedString::from(server.to_owned()))
+}
+
+/// Local repository scanning and the create-repository dialog default folder.
+fn repositories_section(
+    settings: &Settings,
+    controls: &SettingsControls,
+    cx: &App,
+) -> impl IntoElement {
+    let scan_paths = settings.local_repos.scan_paths.clone();
+
+    v_flex()
+        .w_full()
+        .gap_3()
+        .child(setting_block(
+            cx,
+            "Scan Directories",
+            "Directories scanned for local git repositories.",
+            scan_paths_editor(&scan_paths, cx),
+        ))
+        .child(setting_block(
+            cx,
+            "Default Folder",
+            "The folder for newly created repositories.",
+            folder_selector(controls),
+        ))
+}
+
+/// The editable list of scan directories plus an add-directory button,
+/// styled like the grasp-server list.
+fn scan_paths_editor(scan_paths: &[PathBuf], cx: &App) -> impl IntoElement {
+    v_flex()
+        .w_full()
+        .gap_2()
+        .children(scan_paths.iter().enumerate().map(|(ix, path)| {
+            h_flex()
+                .w_full()
+                .gap_1()
+                .items_center()
+                .child(
+                    h_flex()
+                        .h_8()
+                        .w_full()
+                        .px_2()
+                        .bg(cx.theme().muted)
+                        .text_color(cx.theme().muted_foreground)
+                        .text_sm()
+                        .rounded(cx.theme().radius)
+                        .child(path.display().to_string()),
+                )
+                .child(
+                    Button::new(format!("settings-remove-path:{ix}"))
+                        .icon(IconName::Close)
+                        .ghost()
+                        .flex_shrink_0()
+                        .tooltip("Remove")
+                        .on_click(move |_event, _window, cx| {
+                            let store = SettingsStore::global(cx);
+                            store.update(cx, |store, cx| {
+                                store.edit(
+                                    |settings| {
+                                        settings.local_repos.scan_paths.remove(ix);
+                                    },
+                                    cx,
+                                );
+                            });
+                        }),
+                )
+        }))
+        .child(
+            h_flex().justify_end().items_center().child(
+                Button::new("settings-add-path")
+                    .icon(IconName::Plus)
+                    .label("Add directory")
+                    .secondary()
+                    .small()
+                    .on_click(move |_event, _window, cx| add_scan_path(cx)),
+            ),
+        )
+}
+
+/// The default-folder selector: a disabled input showing the effective
+/// folder plus a picker button, matching the create-repository dialog.
+fn folder_selector(controls: &SettingsControls) -> impl IntoElement {
+    let default_folder = controls.default_folder.clone();
+    h_flex()
+        .w_full()
+        .gap_1()
+        .items_center()
+        .child(
+            div()
+                .flex_1()
+                .child(Input::new(&default_folder).disabled(true)),
+        )
+        .child(
+            Button::new("settings-choose-folder")
+                .icon(IconName::Folder)
+                .ghost()
+                .tooltip("Choose folder")
+                .on_click(move |_event, window, cx| {
+                    choose_default_folder(&default_folder, window, cx);
+                }),
+        )
+}
+
+/// Parse the server input (accepting a bare host) and append it to the
+/// default grasp servers.
+fn add_server(input: &Entity<InputState>, window: &mut Window, cx: &mut App) {
+    let value = input.read(cx).value().trim().to_owned();
+    if value.is_empty() {
+        return;
+    }
+    let normalized = if value.contains("://") {
+        value
+    } else {
+        format!("wss://{value}")
+    };
+    if RelayUrl::parse(&normalized).is_err() {
+        return;
+    }
+
+    let store = SettingsStore::global(cx);
+    store.update(cx, |store, cx| {
+        store.edit(
+            |settings| {
+                if !settings.grasp_servers.default_servers.contains(&normalized) {
+                    settings
+                        .grasp_servers
+                        .default_servers
+                        .push(normalized.clone());
+                }
+            },
+            cx,
+        );
+    });
+    input.update(cx, |input, cx| input.set_value("", window, cx));
+}
+
+/// Prompt for directories to add to the local-repository scan.
+fn add_scan_path(cx: &mut App) {
+    let prompt = cx.prompt_for_paths(PathPromptOptions {
+        files: false,
+        directories: true,
+        multiple: true,
+        prompt: Some("Choose directories".into()),
+    });
+
+    cx.spawn(async move |cx| {
+        if let Ok(Ok(Some(paths))) = prompt.await {
+            cx.update(|cx| {
+                let store = SettingsStore::global(cx);
+                store.update(cx, |store, cx| {
+                    store.edit(
+                        |settings| {
+                            for path in paths {
+                                let path = path.to_string_lossy().to_string();
+                                if !settings
+                                    .local_repos
+                                    .scan_paths
+                                    .iter()
+                                    .any(|existing| existing.to_string_lossy() == path)
+                                {
+                                    settings.local_repos.scan_paths.push(path.into());
+                                }
+                            }
+                        },
+                        cx,
+                    );
+                });
+            });
+        }
+    })
+    .detach();
+}
+
+/// Prompt for the folder the Create Repository dialog should default to,
+/// remembering it in the settings and showing it in the disabled input.
+fn choose_default_folder(default_folder: &Entity<InputState>, window: &mut Window, cx: &mut App) {
+    let handle = window.window_handle();
+    let default_folder = default_folder.clone();
+    let prompt = cx.prompt_for_paths(PathPromptOptions {
+        files: false,
+        directories: true,
+        multiple: false,
+        prompt: Some("Choose default folder".into()),
+    });
+
+    cx.spawn(async move |cx| {
+        if let Ok(Ok(Some(mut paths))) = prompt.await
+            && let Some(path) = paths.pop()
+        {
+            let path = path.to_string_lossy().to_string();
+            cx.update_window(handle, |_, window, cx| {
+                let store = SettingsStore::global(cx);
+                store.update(cx, |store, cx| {
+                    store.edit(
+                        |settings| {
+                            settings.create_repository.default_folder = Some(path.clone().into())
+                        },
+                        cx,
+                    );
+                });
+                default_folder.update(cx, |input, cx| input.set_value(path, window, cx));
+            })
+            .ok();
+        }
+    })
+    .detach();
+}
+
+/// Wire a number input to the settings: steps clamp and persist, typed
+/// changes parse, clamp and persist.
+fn wire_number_input(
+    state: &Entity<InputState>,
+    subscriptions: &mut Vec<Subscription>,
+    window_handle: AnyWindowHandle,
+    cx: &mut App,
+    options: NumberFieldOptions,
+    initial: f64,
+    on_change: impl Fn(f64, &mut App) + 'static,
+) {
+    let on_change = Rc::new(on_change);
+    let initial_value = Rc::new(Cell::new(initial));
+    let (min, max, step) = (options.min, options.max, options.step);
+
+    subscriptions.push(cx.subscribe(&state.clone(), {
+        let state = state.clone();
+        let initial_value = initial_value.clone();
+        let on_change = on_change.clone();
+        move |_, event: &NumberInputEvent, cx| {
+            let NumberInputEvent::Step(action) = event;
+            let value = state.read(cx).value();
+            if let Ok(value) = value.parse::<f64>() {
+                let new_value = match action {
+                    StepAction::Increment => value + step,
+                    StepAction::Decrement => value - step,
+                };
+                let clamped = new_value.clamp(min, max);
+                window_handle
+                    .update(cx, |_, window, cx| {
+                        state.update(cx, |input, cx| {
+                            input.set_value(SharedString::from(clamped.to_string()), window, cx);
+                        });
+                    })
+                    .ok();
+                initial_value.set(clamped);
+                on_change(clamped, cx);
+            }
+        }
+    }));
+
+    subscriptions.push(cx.subscribe(&state.clone(), {
+        let state = state.clone();
+        let initial_value = initial_value.clone();
+        let on_change = on_change.clone();
+        move |_, event: &InputEvent, cx| {
+            if matches!(event, InputEvent::Change) {
+                let value = state.read(cx).value();
+                if value == initial_value.get().to_string() {
+                    return;
+                }
+                if let Ok(parsed) = value.parse::<f64>() {
+                    let clamped = parsed.clamp(min, max);
+                    initial_value.set(clamped);
+                    on_change(clamped, cx);
+                    if clamped != parsed {
+                        window_handle
+                            .update(cx, |_, window, cx| {
+                                state.update(cx, |input, cx| {
+                                    input.set_value(
+                                        SharedString::from(clamped.to_string()),
+                                        window,
+                                        cx,
+                                    );
+                                });
+                            })
+                            .ok();
+                    }
+                }
+            }
+        }
+    }));
+}
+
+/// Apply the persisted appearance to the live theme.
+fn apply_appearance(appearance: AppearanceMode, cx: &mut App) {
+    match appearance {
+        AppearanceMode::System => Theme::sync_system_appearance(None, cx),
+        AppearanceMode::Light => Theme::change(ThemeMode::Light, None, cx),
+        AppearanceMode::Dark => Theme::change(ThemeMode::Dark, None, cx),
+    }
+}
+
+/// Re-apply the persisted theme configuration to the live theme.
+fn apply_theme(cx: &mut App) {
+    let store = SettingsStore::global(cx);
+    let settings = store.read(cx).settings().theme.clone();
+
+    let registry = ThemeRegistry::global(cx);
+    let light_config = registry
+        .themes()
+        .get(settings.light_theme.as_str())
+        .cloned();
+    let dark_config = registry.themes().get(settings.dark_theme.as_str()).cloned();
+    let mode = Theme::global(cx).mode;
+
+    let theme = Theme::global_mut(cx);
+    theme.radius = px(settings.radius);
+    theme.radius_lg = px(settings.radius_lg);
+    theme.focus_ring = settings.focus_ring;
+    theme.shadow = settings.shadow;
+    theme.font_size = px(settings.font_size);
+    theme.mono_font_size = px(settings.mono_font_size);
+    if let Some(config) = light_config {
+        theme.light_theme = config;
+    }
+    if let Some(config) = dark_config {
+        theme.dark_theme = config;
+    }
+
+    // Re-apply the active mode so the updated configs take effect.
+    Theme::change(mode, None, cx);
+}