consolidate shared helpers into utils crate

crates/signed_state/src/repo.rs

@@ -392,12 +392,12 @@ impl RepoStore {
                 .into_iter()
                 .filter(|e| !deletions.is_deleted(e));
 
-            let announcement = latest(all_announcements)
+            let announcement = utils::latest(all_announcements)
                 .as_ref()
                 .and_then(Announcement::from_event);
 
             let all_states = states.into_iter().filter(|e| !deletions.is_deleted(e));
-            let state = latest(all_states).map(|state| parse_state(&state));
+            let state = utils::latest(all_states).map(|state| parse_state(&state));
 
             let (mut issues, mut patches, mut pull_requests, mut statuses, mut comments) =
                 (Vec::new(), Vec::new(), Vec::new(), Vec::new(), Vec::new());
@@ -450,10 +450,10 @@ impl RepoStore {
                 }
             }
 
-            sort_newest_first(&mut issues);
-            sort_newest_first(&mut patches);
-            sort_newest_first(&mut pull_requests);
-            sort_oldest_first(&mut comments);
+            utils::sort_newest_first(&mut issues);
+            utils::sort_newest_first(&mut patches);
+            utils::sort_newest_first(&mut pull_requests);
+            utils::sort_oldest_first(&mut comments);
 
             let maintainers = announcement
                 .as_ref()
@@ -1447,13 +1447,6 @@ impl RepoStore {
     }
 }
 
-fn latest<I>(events: I) -> Option<Event>
-where
-    I: IntoIterator<Item = Event>,
-{
-    events.into_iter().max_by_key(|e| e.created_at)
-}
-
 fn status_of(status_by_root: &HashMap<EventId, RepoStatus>, root: &Event) -> RepoStatus {
     status_by_root
         .get(&root.id)
@@ -1492,14 +1485,6 @@ fn resolve_statuses(
         .collect()
 }
 
-fn sort_newest_first(events: &mut [Event]) {
-    events.sort_by_key(|e| std::cmp::Reverse(e.created_at));
-}
-
-fn sort_oldest_first(events: &mut [Event]) {
-    events.sort_by_key(|e| e.created_at);
-}
-
 /// The proposed commit of a `git format-patch` output.
 /// It is the `From <commit>` header on the first line.
 fn patch_current_commit(patch: &str) -> Option<&str> {