Author SHA1 Message Date
reya a87030e929 chore: release version 0.2.0-alpha
Rust / build (macos-latest, stable) (push) Canceled after 0s
Rust / build (ubuntu-latest, stable) (push) Canceled after 0s
Rust / build (windows-latest, stable) (push) Canceled after 0s
Build and Release / Build macos-x64 (push) Canceled after 0s
Build and Release / Build macos-arm64 (push) Canceled after 0s
Build and Release / Build linux-arm64 (push) Canceled after 0s
Build and Release / Build linux-x64 (push) Canceled after 0s
Build and Release / Build windows-arm64 (push) Canceled after 0s
Build and Release / Build windows-x64 (push) Canceled after 0s
Build and Release / Create Release (push) Canceled after 0s
2026-09-27 14:22:59 +07:00
reya 272ddf2674 chore: connect bootstrap relays on demand (#25)
Rust / build (macos-latest, stable) (push) Canceled after 0s
Rust / build (ubuntu-latest, stable) (push) Canceled after 0s
Rust / build (windows-latest, stable) (push) Canceled after 0s
Reviewed-on: #25
2026-09-27 07:20:54 +00:00
reya fa50e9f153 feat: add event fetching strategy (#24)
Rust / build (macos-latest, stable) (push) Canceled after 0s
Rust / build (ubuntu-latest, stable) (push) Canceled after 0s
Rust / build (windows-latest, stable) (push) Canceled after 0s
Reviewed-on: #24
2026-09-27 02:50:11 +00:00
15 changed files with 199 additions and 275 deletions
+2
View File
@@ -81,6 +81,8 @@ Both `cx.spawn` and `cx.background_spawn` return a `Task<R>`, which is a future
A task which doesn't do anything but provide a value can be created with `Task::ready(value)`. A task which doesn't do anything but provide a value can be created with `Task::ready(value)`.
Prefer keeping a task in a field over `.detach()` when the work belongs to a view or store. A detached task outlives the view that started it (for example, a repository panel the user has closed), while a task stored in a field is cancelled when that struct drops. A finished `Task` held in a container is not reaped by GPUI - it stays alive until its handle is dropped - so if the container can accumulate many runs, either drop the finished handles before pushing a new one, or hold a single `Option<Task<_>>` and replace it.
## Elements ## Elements
The `Render` trait is used to render some state into an element tree that is laid out using flexbox layout. An `Entity<T>` where `T` implements `Render` is sometimes called a "view". The `Render` trait is used to render some state into an element tree that is laid out using flexbox layout. An `Entity<T>` where `T` implements `Render` is sometimes called a "view".
+6
View File
@@ -15,14 +15,20 @@
- Migrate the GPUI foundation to the published `gpui-pre` crates and GPUI Kit 0.6, off the zed and gpui-component git pins - Migrate the GPUI foundation to the published `gpui-pre` crates and GPUI Kit 0.6, off the zed and gpui-component git pins
- Use the pixel avatar as the single fallback for a missing picture, sized and rounded to match the other avatars - Use the pixel avatar as the single fallback for a missing picture, sized and rounded to match the other avatars
- Redesign the dock tab bar, using muted grey active tab, added close buttons, double-click to zoom, and removed panel toolbar - Redesign the dock tab bar, using muted grey active tab, added close buttons, double-click to zoom, and removed panel toolbar
- Connect to bootstrap relays on demand instead of at startup
- Fetch profile metadata in batches of 100 authors, applying every requested profile in a single database query
- Prefetch the 500 most recent profiles at startup instead of 200
### Fixed ### Fixed
- Render every avatar at one consistent size, where a surrounding border had shrunk pictures by two pixels and the pixel avatar ignored an explicit size - Render every avatar at one consistent size, where a surrounding border had shrunk pictures by two pixels and the pixel avatar ignored an explicit size
- Date repositories from their repository state event, so the explore list and open repository views show the latest push instead of the announcement date - Date repositories from their repository state event, so the explore list and open repository views show the latest push instead of the announcement date
- Fix background tasks outliving their view, so a closed repository panel or pull request view stops fetching and publishing on its own
### Removed ### Removed
- Remove cover note support, the kind-1624 GitWorkshop and `ngit` extension outside the NIP-34
### Deprecated ### Deprecated
## v0.1.0-alpha - 2026/09/14 ## v0.1.0-alpha - 2026/09/14
+1 -1
View File
@@ -4,7 +4,7 @@ members = ["crates/*", "desktop"]
default-members = ["desktop"] default-members = ["desktop"]
[workspace.package] [workspace.package]
version = "0.1.0-alpha" version = "0.2.0-alpha"
edition = "2024" edition = "2024"
publish = false publish = false
+37 -46
View File
@@ -21,10 +21,8 @@ use crate::repos::RepoListStore;
pub const USER_KEYRING: &str = "Signed Safe Storage"; pub const USER_KEYRING: &str = "Signed Safe Storage";
/// Timeout for NIP-46 signer responses. /// Timeout for NIP-46 signer responses.
pub const NOSTR_CONNECT_TIMEOUT: u64 = 60; pub const NOSTR_CONNECT_TIMEOUT: u64 = 60;
/// Relays connected at startup, before any user-specific relay config is known. /// Relays connected at startup, before any user-specific relay config is known.
pub const BOOTSTRAP_RELAYS: [&str; 2] = ["wss://relay.ditto.pub", "wss://index.ngit.dev"]; pub const BOOTSTRAP_RELAYS: [&str; 2] = ["wss://relay.ditto.pub", "wss://index.ngit.dev"];
/// Relays used to index the user's NIP-65 relay list. /// Relays used to index the user's NIP-65 relay list.
pub const INDEXER_RELAYS: [&str; 2] = ["wss://indexer.coracle.social", "wss://user.kindpag.es"]; pub const INDEXER_RELAYS: [&str; 2] = ["wss://indexer.coracle.social", "wss://user.kindpag.es"];
@@ -151,9 +149,10 @@ impl Backend {
pump.detach(); pump.detach();
cx.defer(move |cx| { cx.defer(move |cx| {
if let Err(error) = weak.update(cx, |this, cx| this.bootstrap(cx)) { weak.update(cx, |this, cx| {
log::warn!("backend dropped before bootstrap could run: {error}"); this.restore_session(cx);
} })
.ok();
}); });
Self { Self {
@@ -167,42 +166,6 @@ impl Backend {
} }
} }
fn bootstrap(&mut self, cx: &mut Context<Self>) {
let client = self.client.clone();
let task = cx.background_spawn(async move {
for url in BOOTSTRAP_RELAYS {
client.add_relay(url).await?;
}
for url in INDEXER_RELAYS {
client
.add_relay(url)
.capabilities(RelayCapabilities::DISCOVERY)
.await?;
}
client.connect().await;
Ok::<(), Error>(())
});
let notify_task: Task<Result<(), Error>> = cx.spawn(async move |this, cx| {
match task.await {
Ok(()) => {
this.update(cx, |this, cx| {
this.restore_session(cx);
})?;
}
Err(e) => {
this.update(cx, |_this, cx| cx.emit(BackendEvent::error(e.to_string())))?;
}
}
Ok::<(), Error>(())
});
notify_task.detach();
}
/// Restore the saved session from the Keyring. /// Restore the saved session from the Keyring.
/// ///
/// - Emits [`BackendEvent::SignerRequired`] when no credential is stored. /// - Emits [`BackendEvent::SignerRequired`] when no credential is stored.
@@ -227,7 +190,9 @@ impl Backend {
let result = async { let result = async {
if content.starts_with("nsec1") { if content.starts_with("nsec1") {
let keys = Keys::new(SecretKey::parse(&content)?); let keys = Keys::new(SecretKey::parse(&content)?);
this.update(cx, |this, cx| this.set_signer(keys, cx))?; this.update(cx, |this, cx| {
this.set_signer(keys, cx);
})?;
} else if content.starts_with("bunker://") { } else if content.starts_with("bunker://") {
let (base, keys) = extract_master_key(&content); let (base, keys) = extract_master_key(&content);
let uri = NostrConnectUri::parse(base)?; let uri = NostrConnectUri::parse(base)?;
@@ -238,14 +203,19 @@ impl Backend {
None, None,
)?; )?;
signer.auth_url_handler(SignedAuthUrlHandler); signer.auth_url_handler(SignedAuthUrlHandler);
this.update(cx, |this, cx| this.set_signer(signer, cx))?;
this.update(cx, |this, cx| {
this.set_signer(signer, cx);
})?;
} else if content.starts_with("ncryptsec1") { } else if content.starts_with("ncryptsec1") {
this.update(cx, |this, cx| { this.update(cx, |this, cx| {
this.passphrase_required = true; this.passphrase_required = true;
cx.emit(BackendEvent::PassphraseRequired); cx.emit(BackendEvent::PassphraseRequired);
})?; })?;
} else { } else {
this.update(cx, |_this, cx| cx.emit(BackendEvent::SignerRequired))?; this.update(cx, |_this, cx| {
cx.emit(BackendEvent::SignerRequired);
})?;
} }
Ok::<_, Error>(()) Ok::<_, Error>(())
@@ -1066,7 +1036,7 @@ impl Backend {
) )
.await?; .await?;
for url in user_grasp_list_servers(client.clone(), public_key).await? { for url in user_grasp_list_servers(&client, public_key).await? {
client.add_relay(url).and_connect().await.ok(); client.add_relay(url).and_connect().await.ok();
} }
@@ -1424,10 +1394,29 @@ async fn connect_repo_relays(
Ok(()) Ok(())
} }
/// Add and connect the startup relays.
async fn ensure_bootstrap_relays(client: &Client) -> Result<(), Error> {
for url in BOOTSTRAP_RELAYS {
client.add_relay(url).and_connect().await?;
}
for url in INDEXER_RELAYS {
client
.add_relay(url)
.capabilities(RelayCapabilities::DISCOVERY)
.and_connect()
.await?;
}
Ok(())
}
pub(crate) async fn subscribe_bootstrap_only( pub(crate) async fn subscribe_bootstrap_only(
client: &Client, client: &Client,
filters: Vec<Filter>, filters: Vec<Filter>,
) -> Result<(), Error> { ) -> Result<(), Error> {
ensure_bootstrap_relays(client).await?;
let opts = SubscribeAutoCloseOptions::default() let opts = SubscribeAutoCloseOptions::default()
.exit_policy(ReqExitPolicy::ExitOnEOSE) .exit_policy(ReqExitPolicy::ExitOnEOSE)
.timeout(Some(Duration::from_secs(10))); .timeout(Some(Duration::from_secs(10)));
@@ -1447,6 +1436,8 @@ pub(crate) async fn sync_bootstrap_only(
filter: Filter, filter: Filter,
opts: SyncOptions, opts: SyncOptions,
) -> Result<SyncSummary, Error> { ) -> Result<SyncSummary, Error> {
ensure_bootstrap_relays(client).await?;
let output = client let output = client
.sync(filter) .sync(filter)
.with(BOOTSTRAP_RELAYS) .with(BOOTSTRAP_RELAYS)
@@ -1525,7 +1516,7 @@ fn latest_grasp_list_servers(events: Vec<Event>) -> Vec<RelayUrl> {
} }
pub async fn user_grasp_list_servers( pub async fn user_grasp_list_servers(
client: Client, client: &Client,
user: PublicKey, user: PublicKey,
) -> Result<Vec<RelayUrl>, Error> { ) -> Result<Vec<RelayUrl>, Error> {
let events: Vec<Event> = client let events: Vec<Event> = client
+4 -46
View File
@@ -17,15 +17,9 @@ use crate::repos::RepoListStore;
const REFRESH_DEBOUNCE: Duration = Duration::from_millis(300); const REFRESH_DEBOUNCE: Duration = Duration::from_millis(300);
/// How often the statuses are recomputed against the local refs. /// How often the statuses are recomputed against the local refs.
///
/// A commit lands in a checkout long before the remote reconciliation cadence,
/// so this fast pass surfaces ready-to-push and ready-to-contribute checkouts
/// within a second or two. It reads the tracking refs only, no network.
const LOCAL_POLL: Duration = Duration::from_secs(2); const LOCAL_POLL: Duration = Duration::from_secs(2);
/// How often a full pass refreshes the remotes while any repository panel is open. /// How often a full pass refreshes the remotes while any repository panel is open.
const STATUS_POLL: Duration = Duration::from_secs(15); const STATUS_POLL: Duration = Duration::from_secs(15);
/// Remote refresh interval for the `ready to push` badges of the user's own repositories. /// Remote refresh interval for the `ready to push` badges of the user's own repositories.
const PUSH_POLL: Duration = Duration::from_secs(60); const PUSH_POLL: Duration = Duration::from_secs(60);
@@ -46,10 +40,6 @@ pub struct CheckoutStatus {
/// Commit the branch points at, for tip-based PR dedupe. /// Commit the branch points at, for tip-based PR dedupe.
pub head: String, pub head: String,
/// What the branch is compared against. /// What the branch is compared against.
/// For ready-to-contribute statuses, the announced HEAD branch.
/// The fallbacks are `main`, then the first local branch.
/// For ready-to-push statuses, the remote-tracking ref.
/// Unpushed commits are counted against it.
/// ///
/// It is `refs/remotes/origin/<branch>`, else `origin/HEAD` for new branches. /// It is `refs/remotes/origin/<branch>`, else `origin/HEAD` for new branches.
pub base: String, pub base: String,
@@ -67,11 +57,6 @@ struct Remembered {
} }
/// Global store of local-checkout associations and per-checkout statuses. /// Global store of local-checkout associations and per-checkout statuses.
///
/// Readers (the sidebar rows, the repository panels) observe this store and
/// derive what they display from their own snapshots, so publishing needs no
/// fine-grained entities: the store notifies when a slice changed and each
/// reader re-derives only what it shows.
pub struct CheckoutsStore { pub struct CheckoutsStore {
/// Checkout paths per announced repository. /// Checkout paths per announced repository.
by_repo: HashMap<RepoAddr, Vec<PathBuf>>, by_repo: HashMap<RepoAddr, Vec<PathBuf>>,
@@ -144,6 +129,7 @@ impl CheckoutsStore {
this.statuses.clear(); this.statuses.clear();
this.push_statuses.clear(); this.push_statuses.clear();
cx.notify(); cx.notify();
this.refresh(cx); this.refresh(cx);
} }
})); }));
@@ -282,9 +268,6 @@ impl CheckoutsStore {
} }
/// Re-resolve the associations and the requested statuses. /// Re-resolve the associations and the requested statuses.
///
/// Requests arriving while a pass runs fold into a follow-up, requests
/// arriving while the debounce timer is pending are dropped.
pub fn refresh(&mut self, cx: &mut Context<Self>) { pub fn refresh(&mut self, cx: &mut Context<Self>) {
if self.debounce_pending || self.refresh.request() != RefreshRequest::Schedule { if self.debounce_pending || self.refresh.request() != RefreshRequest::Schedule {
return; return;
@@ -300,12 +283,6 @@ impl CheckoutsStore {
} }
/// One full resolve and apply cycle, the debounced entry point. /// One full resolve and apply cycle, the debounced entry point.
///
/// Re-resolves the associations from the settings, the scan and the
/// announcements, then recomputes the requested statuses against freshly
/// fetched remotes. Full passes run on every input change and on the
/// remote reconciliation cadence ([`Self::local_tick`]); they also restart
/// the fast local pass.
fn run_refresh(&mut self, cx: &mut Context<Self>) { fn run_refresh(&mut self, cx: &mut Context<Self>) {
self.debounce_pending = false; self.debounce_pending = false;
self.refresh.begin(); self.refresh.begin();
@@ -431,10 +408,6 @@ impl CheckoutsStore {
} }
/// Schedule the fast local status pass, unless one is already pending. /// Schedule the fast local status pass, unless one is already pending.
///
/// Every [`LOCAL_POLL`] the pass recomputes the requested statuses against
/// the local refs, with no network, so a new commit in a checkout surfaces in
/// a second or two instead of at the next remote reconciliation.
fn schedule_local_pass(&mut self, cx: &mut Context<Self>) { fn schedule_local_pass(&mut self, cx: &mut Context<Self>) {
if self.local_pending { if self.local_pending {
return; return;
@@ -452,10 +425,6 @@ impl CheckoutsStore {
} }
/// The fast local status pass. /// The fast local status pass.
///
/// Recomputes the statuses against the local refs; when the remote
/// reconciliation cadence elapsed, it runs a full pass instead so pushes
/// made elsewhere do not linger as `to push`.
fn local_tick(&mut self, cx: &mut Context<Self>) { fn local_tick(&mut self, cx: &mut Context<Self>) {
// Nothing watched: the chain idles out until a new request restarts it. // Nothing watched: the chain idles out until a new request restarts it.
if self.status_requested.is_empty() && self.push_requested.is_empty() { if self.status_requested.is_empty() && self.push_requested.is_empty() {
@@ -490,10 +459,6 @@ impl CheckoutsStore {
} }
/// Recompute the requested statuses against the tracking refs only. /// Recompute the requested statuses against the tracking refs only.
///
/// The refs were last refreshed by a full pass. Comparing against them is
/// enough to pick up new local commits, and skipping the network keeps
/// this pass cheap enough to run every [`LOCAL_POLL`].
fn run_local_statuses(&mut self, cx: &mut Context<Self>) { fn run_local_statuses(&mut self, cx: &mut Context<Self>) {
let associations = self.by_repo.clone(); let associations = self.by_repo.clone();
@@ -635,10 +600,6 @@ fn checkout_status(path: &Path, announced_head: Option<&str>) -> Option<Checkout
} }
/// The `ready to push` status of one checkout of the user's own repository. /// The `ready to push` status of one checkout of the user's own repository.
///
/// `fetch` refreshes the remote heads first, so a full pass sees pushes made
/// elsewhere; the fast local pass skips it and compares against the tracking
/// refs left by the last full pass, which is enough to detect local commits.
fn checkout_push_status(path: &Path, fetch: bool) -> Option<CheckoutStatus> { fn checkout_push_status(path: &Path, fetch: bool) -> Option<CheckoutStatus> {
if signed_git::worktree_dirty(path) { if signed_git::worktree_dirty(path) {
return None; return None;
@@ -649,8 +610,6 @@ fn checkout_push_status(path: &Path, fetch: bool) -> Option<CheckoutStatus> {
let origin = signed_git::origin_url(path).ok().flatten()?; let origin = signed_git::origin_url(path).ok().flatten()?;
if fetch { if fetch {
// Refresh the remote heads first.
// Commits made elsewhere or pushed from another machine must not linger as `to push`.
signed_git::fetch_repo_refs(path, &[origin], "+refs/heads/*:refs/remotes/origin/*").ok(); signed_git::fetch_repo_refs(path, &[origin], "+refs/heads/*:refs/remotes/origin/*").ok();
} }
@@ -678,10 +637,6 @@ fn checkout_push_status(path: &Path, fetch: bool) -> Option<CheckoutStatus> {
} }
/// Compute the requested statuses against the checkout paths of `associations`. /// Compute the requested statuses against the checkout paths of `associations`.
///
/// Shared by the full and the local pass. `fetch` refreshes the checkouts'
/// remote heads first, so the full pass sees remote moves; the fast local
/// pass reads the tracking refs only, which is enough to detect local commits.
fn compute_statuses( fn compute_statuses(
associations: &HashMap<RepoAddr, Vec<PathBuf>>, associations: &HashMap<RepoAddr, Vec<PathBuf>>,
requested: &[(RepoAddr, Option<String>)], requested: &[(RepoAddr, Option<String>)],
@@ -737,12 +692,14 @@ pub fn pr_proposes_checkout(
if pr.kind != Kind::GitPullRequest || !open || pr.pubkey != user { if pr.kind != Kind::GitPullRequest || !open || pr.pubkey != user {
return false; return false;
} }
let branch_matches = pr let branch_matches = pr
.tags .tags
.iter() .iter()
.find(|t| t.kind() == "branch-name") .find(|t| t.kind() == "branch-name")
.and_then(|t| t.content()) .and_then(|t| t.content())
.is_some_and(|name| name == checkout.branch); .is_some_and(|name| name == checkout.branch);
// A renamed branch falls back to the proposed tip commit. // A renamed branch falls back to the proposed tip commit.
let tip_matches = pr let tip_matches = pr
.tags .tags
@@ -750,6 +707,7 @@ pub fn pr_proposes_checkout(
.find(|t| t.kind() == "c") .find(|t| t.kind() == "c")
.and_then(|t| t.content()) .and_then(|t| t.content())
.is_some_and(|tip| tip == checkout.head); .is_some_and(|tip| tip == checkout.head);
branch_matches || tip_matches branch_matches || tip_matches
} }
+7 -2
View File
@@ -104,11 +104,16 @@ impl Inbox {
/// Sign the state with a random key and store it locally. /// Sign the state with a random key and store it locally.
fn persist(&mut self, cx: &mut Context<Self>) { fn persist(&mut self, cx: &mut Context<Self>) {
let Some(me) = Backend::global(cx).read(cx).current_user() else { let backend = Backend::global(cx);
let (me, client) = {
let backend = backend.read(cx);
(backend.current_user(), backend.client())
};
let Some(me) = me else {
return; return;
}; };
let client = Backend::global(cx).read(cx).client();
let state = self.state.clone(); let state = self.state.clone();
let task: Task<Result<(), Error>> = cx.background_spawn(async move { let task: Task<Result<(), Error>> = cx.background_spawn(async move {
+50 -81
View File
@@ -5,14 +5,20 @@ use std::time::{Duration, Instant};
use anyhow::Error; use anyhow::Error;
use flume::{Receiver, Sender}; use flume::{Receiver, Sender};
use gpui::{ use gpui::{
App, AppContext, AsyncApp, Context, Entity, Global, SharedString, Subscription, Task, App, AppContext, AsyncApp, Context, Entity, Global, SharedString, Subscription, WeakEntity,
WeakEntity,
}; };
use nostr_sdk::prelude::*; use nostr_sdk::prelude::*;
use utils::shorten_pubkey; use utils::shorten_pubkey;
use crate::backend::{Backend, BackendEvent, sync_bootstrap_only}; use crate::backend::{Backend, BackendEvent, sync_bootstrap_only};
/// How long to wait for more requests before firing a batched fetch.
const BATCH_TIMEOUT: Duration = Duration::from_millis(500);
/// Max authors per profile request, keeping each filter within relay limits.
const REQUEST_CHUNK: usize = 100;
/// Recent profiles prefetched at startup and read back from the cache.
const WARM_LIMIT: usize = 500;
/// A user profile as plain data for the UI, from the kind-0 metadata. /// A user profile as plain data for the UI, from the kind-0 metadata.
#[derive(Debug, Clone)] #[derive(Debug, Clone)]
pub struct Profile { pub struct Profile {
@@ -62,9 +68,6 @@ impl Profile {
} }
} }
/// How long to wait for more requests before firing a batched sync.
const BATCH_TIMEOUT: Duration = Duration::from_millis(500);
/// Global profile cache. /// Global profile cache.
/// ///
/// Profiles are fetched in batches and kept as plain data. /// Profiles are fetched in batches and kept as plain data.
@@ -92,30 +95,26 @@ impl ProfileStore {
pub(crate) fn new(cx: &mut Context<Self>) -> Self { pub(crate) fn new(cx: &mut Context<Self>) -> Self {
let backend = Backend::global(cx); let backend = Backend::global(cx);
let client = backend.read(cx).client();
let subscription = cx.subscribe(&backend, |this, _backend, event, cx| {
if let BackendEvent::ProfileUpdates(authors) = event {
for author in authors {
this.apply_author(*author, cx);
}
}
});
let entity = cx.entity().downgrade(); let entity = cx.entity().downgrade();
let entity_clone = entity.clone(); let client = backend.read(cx).client();
let (sender, receiver) = flume::unbounded::<PublicKey>(); let (sender, receiver) = flume::unbounded::<PublicKey>();
cx.spawn(async move |_this, cx| { let subscription = cx.subscribe(&backend, |this, _backend, event, cx| {
Self::handle_requests(entity, &client, &receiver, cx).await if let BackendEvent::ProfileUpdates(authors) = event {
this.apply_authors(authors.clone(), cx);
}
});
cx.spawn(async move |this, cx| {
if let Err(e) = Self::handle_requests(this, &client, &receiver, cx).await {
log::error!("Failed to handle requests: {e}");
}
}) })
.detach(); .detach();
cx.defer(move |cx| { cx.defer(move |cx| {
if let Err(error) = entity_clone.update(cx, |this, cx| this.load(cx)) { entity.update(cx, |this, cx| this.load(cx)).ok();
log::warn!("profile store dropped before initial load could run: {error}");
}
}); });
Self { Self {
@@ -150,11 +149,9 @@ impl ProfileStore {
let client = backend.read(cx).client(); let client = backend.read(cx).client();
let work = cx.background_spawn(async move { let work = cx.background_spawn(async move {
let filter = Filter::new().kind(Kind::Metadata).limit(200); let filter = Filter::new().kind(Kind::Metadata).limit(WARM_LIMIT);
let events = client.database().query(filter).await?; let events = client.database().query(filter).await?;
// Parse off the main thread.
// Only plain profiles cross back.
let profiles: Vec<Profile> = events let profiles: Vec<Profile> = events
.into_iter() .into_iter()
.map(|event| { .map(|event| {
@@ -166,7 +163,7 @@ impl ProfileStore {
Ok::<_, Error>(profiles) Ok::<_, Error>(profiles)
}); });
let task: Task<Result<(), Error>> = cx.spawn(async move |this, cx| { cx.spawn(async move |this, cx| {
let profiles = work.await?; let profiles = work.await?;
this.update(cx, |this, cx| { this.update(cx, |this, cx| {
@@ -176,51 +173,13 @@ impl ProfileStore {
cx.notify(); cx.notify();
})?; })?;
Ok(()) Ok::<_, Error>(())
}); })
task.detach(); .detach();
} }
fn apply_author(&mut self, public_key: PublicKey, cx: &mut Context<Self>) { /// Re-read the latest metadata of `authors` from the local database in one query.
let backend = Backend::global(cx); fn apply_authors(&mut self, authors: Vec<PublicKey>, cx: &mut Context<Self>) {
let client = backend.read(cx).client();
let work = cx.background_spawn(async move {
let filter = Filter::new().kind(Kind::Metadata).author(public_key);
let events = client.database().query(filter).await?;
// Parse off the main thread.
// Only the profile crosses back.
let profile = events
.into_iter()
.max_by_key(|e| e.created_at)
.map(|event| {
let metadata = Metadata::from_json(event.content).unwrap_or_default();
Profile::new(event.pubkey, metadata)
});
Ok::<_, Error>(profile)
});
let task: Task<Result<(), Error>> = cx.spawn(async move |this, cx| {
let profile = work.await?;
this.update(cx, |this, cx| {
if let Some(profile) = profile {
this.profiles.insert(profile.public_key(), profile);
cx.notify();
}
})?;
Ok(())
});
task.detach();
}
/// Re-read the latest metadata of every requested author from the local database.
fn apply_seen(&mut self, cx: &mut Context<Self>) {
let authors: Vec<PublicKey> = self.seen.borrow().iter().copied().collect();
if authors.is_empty() { if authors.is_empty() {
return; return;
} }
@@ -231,9 +190,9 @@ impl ProfileStore {
let work = cx.background_spawn(async move { let work = cx.background_spawn(async move {
let filter = Filter::new().kind(Kind::Metadata).authors(authors); let filter = Filter::new().kind(Kind::Metadata).authors(authors);
let events = client.database().query(filter).await?; let events = client.database().query(filter).await?;
// Pick the latest metadata per author off the main thread. // Pick the latest metadata per author off the main thread.
let mut latest: HashMap<PublicKey, (Timestamp, Metadata)> = HashMap::new(); let mut latest: HashMap<PublicKey, (Timestamp, Metadata)> = HashMap::new();
for event in events { for event in events {
match latest.get(&event.pubkey) { match latest.get(&event.pubkey) {
Some((ts, _)) if *ts >= event.created_at => {} Some((ts, _)) if *ts >= event.created_at => {}
@@ -257,7 +216,7 @@ impl ProfileStore {
Ok::<_, Error>(profiles) Ok::<_, Error>(profiles)
}); });
let task: Task<Result<(), Error>> = cx.spawn(async move |this, cx| { cx.spawn(async move |this, cx| {
let profiles = work.await?; let profiles = work.await?;
this.update(cx, |this, cx| { this.update(cx, |this, cx| {
@@ -267,14 +226,18 @@ impl ProfileStore {
cx.notify(); cx.notify();
})?; })?;
Ok(()) Ok::<_, Error>(())
}); })
task.detach(); .detach();
} }
/// Sync metadata for requested authors in batches, debounced to collect requests. /// Re-read the latest metadata of every requested author from the local database.
/// fn apply_seen(&mut self, cx: &mut Context<Self>) {
/// After each batch, the seen profiles are re-read from the database on the main thread. let authors: Vec<PublicKey> = self.seen.borrow().iter().copied().collect();
self.apply_authors(authors, cx);
}
/// Fetch metadata for requested authors in batches, debounced to collect requests.
async fn handle_requests( async fn handle_requests(
this: WeakEntity<ProfileStore>, this: WeakEntity<ProfileStore>,
client: &Client, client: &Client,
@@ -316,15 +279,21 @@ impl ProfileStore {
} }
} }
let authors: Vec<PublicKey> = batch.drain().collect();
for chunk in authors.chunks(REQUEST_CHUNK) {
let opts = SyncOptions::default();
let filter = Filter::new() let filter = Filter::new()
.kind(Kind::Metadata) .kind(Kind::Metadata)
.authors(batch.drain().collect::<Vec<PublicKey>>()); .authors(chunk.iter().copied());
match sync_bootstrap_only(client, filter, SyncOptions::default()).await { if let Err(e) = sync_bootstrap_only(client, filter, opts).await {
Ok(_) => { log::warn!("profile fetch failed: {e}");
this.update(cx, |this, cx| this.apply_seen(cx)).ok();
} }
Err(e) => log::warn!("profile sync failed: {e}"), }
if this.update(cx, |this, cx| this.apply_seen(cx)).is_err() {
return Ok(());
} }
} }
} }
-4
View File
@@ -18,10 +18,6 @@ impl RefreshGate {
self.running self.running
} }
/// A new refresh request arrived.
///
/// Folded into a follow-up run while one is in flight, otherwise the
/// caller starts the run itself.
pub fn request(&mut self) -> RefreshRequest { pub fn request(&mut self) -> RefreshRequest {
if self.running { if self.running {
self.dirty = true; self.dirty = true;
+60 -78
View File
@@ -4,7 +4,7 @@ use std::path::PathBuf;
use anyhow::{Error, bail}; use anyhow::{Error, bail};
use bitcoin_hashes::sha1::Hash as Sha1Hash; use bitcoin_hashes::sha1::Hash as Sha1Hash;
use gpui::{App, AppContext, AsyncApp, Context, SharedString, Subscription, Task, WeakEntity}; use gpui::{App, AppContext, Context, SharedString, Subscription, Task};
use nostr::event::IntoEventBuilder; use nostr::event::IntoEventBuilder;
use nostr_sdk::prelude::*; use nostr_sdk::prelude::*;
use settings::{EventFetchingStrategy, SettingsStore}; use settings::{EventFetchingStrategy, SettingsStore};
@@ -13,6 +13,7 @@ use signed_core::{
pull_request_patches, pull_request_patches,
}; };
use signed_git::Nip34Binding; use signed_git::Nip34Binding;
use signed_nostr::UniversalSigner;
use crate::backend::{ use crate::backend::{
Backend, BackendEvent, grasp_base_url, grasp06_prs_url, pr_clone_urls, require_relay_accepted, Backend, BackendEvent, grasp_base_url, grasp06_prs_url, pr_clone_urls, require_relay_accepted,
@@ -20,7 +21,6 @@ use crate::backend::{
}; };
use crate::checkouts::CheckoutsStore; use crate::checkouts::CheckoutsStore;
use crate::git_store::ensure_repo_mirror; use crate::git_store::ensure_repo_mirror;
use crate::refresh::{RefreshGate, RefreshRequest};
use crate::repos::RepoListStore; use crate::repos::RepoListStore;
/// Maximum size of one patch event. /// Maximum size of one patch event.
@@ -31,7 +31,6 @@ const MAX_PATCH_EVENT_BYTES: usize = 60 * 1024;
/// Per-repository store. /// Per-repository store.
/// ///
/// Holds the announcement, state, issues, patches, PRs, comments and resolved statuses. /// Holds the announcement, state, issues, patches, PRs, comments and resolved statuses.
/// Always derived from the local database.
pub struct RepoStore { pub struct RepoStore {
/// NIP-34 address. `None` while the repository is local-only. /// NIP-34 address. `None` while the repository is local-only.
addr: Option<RepoAddr>, addr: Option<RepoAddr>,
@@ -89,7 +88,8 @@ pub struct RepoStore {
/// ///
/// Avoids re-running the maintainer Auto sync on every refresh. /// Avoids re-running the maintainer Auto sync on every refresh.
synced_maintainers: HashSet<PublicKey>, synced_maintainers: HashSet<PublicKey>,
refresh: RefreshGate, /// In-flight tasks, cancelled when the store drops.
tasks: Vec<Task<Result<(), Error>>>,
/// Backend subscription of an announced repository. `None` while local-only. /// Backend subscription of an announced repository. `None` while local-only.
_subscription: Option<Subscription>, _subscription: Option<Subscription>,
} }
@@ -138,7 +138,7 @@ impl RepoStore {
repo_relays: HashSet::new(), repo_relays: HashSet::new(),
root_fetches: HashSet::new(), root_fetches: HashSet::new(),
synced_maintainers: HashSet::new(), synced_maintainers: HashSet::new(),
refresh: RefreshGate::default(), tasks: Vec::new(),
_subscription: Some(subscription), _subscription: Some(subscription),
} }
} }
@@ -167,7 +167,7 @@ impl RepoStore {
repo_relays: HashSet::new(), repo_relays: HashSet::new(),
root_fetches: HashSet::new(), root_fetches: HashSet::new(),
synced_maintainers: HashSet::new(), synced_maintainers: HashSet::new(),
refresh: RefreshGate::default(), tasks: Vec::new(),
_subscription: None, _subscription: None,
} }
} }
@@ -365,11 +365,6 @@ impl RepoStore {
if self.addr.is_none() { if self.addr.is_none() {
return; return;
} }
if self.refresh.request() != RefreshRequest::Schedule {
return;
}
self.run_refresh(cx); self.run_refresh(cx);
} }
@@ -378,8 +373,6 @@ impl RepoStore {
return; return;
}; };
self.refresh.begin();
let backend = Backend::global(cx); let backend = Backend::global(cx);
let client = backend.read(cx).client(); let client = backend.read(cx).client();
@@ -498,7 +491,7 @@ impl RepoStore {
)) ))
}); });
cx.spawn(async move |this, cx| { let task = cx.spawn(async move |this, cx| {
let ( let (
announcement, announcement,
state, state,
@@ -513,14 +506,13 @@ impl RepoStore {
Ok(data) => data, Ok(data) => data,
Err(e) => { Err(e) => {
return this.update(cx, |this, cx| { return this.update(cx, |this, cx| {
this.refresh.abort();
this.last_error = Some(e.to_string()); this.last_error = Some(e.to_string());
cx.notify(); cx.notify();
}); });
} }
}; };
let again = this.update(cx, |this, cx| { this.update(cx, |this, cx| {
let keep_hint = announcement.is_none() && !this.loaded; let keep_hint = announcement.is_none() && !this.loaded;
let first_pass = !this.loaded; let first_pass = !this.loaded;
@@ -604,17 +596,12 @@ impl RepoStore {
if changed { if changed {
cx.notify(); cx.notify();
} }
this.refresh.finish()
})?; })?;
if again {
this.update(cx, |this, cx| this.refresh(cx))?;
}
Ok(()) Ok(())
}) });
.detach();
self.tasks.push(task);
} }
/// Resolve the status of a root event, an issue, patch or PR, per NIP-34. /// Resolve the status of a root event, an issue, patch or PR, per NIP-34.
@@ -747,9 +734,12 @@ impl RepoStore {
}; };
let backend = Backend::global(cx); let backend = Backend::global(cx);
let signer = backend.read(cx).signer(); let (signer, client, user) = {
let backend = backend.read(cx);
(backend.signer(), backend.client(), backend.current_user())
};
let Some(user) = backend.read(cx).current_user() else { let Some(user) = user else {
self.last_error = Some("Sign in to open a pull request".into()); self.last_error = Some("Sign in to open a pull request".into());
cx.notify(); cx.notify();
return; return;
@@ -784,12 +774,12 @@ impl RepoStore {
.collect() .collect()
}; };
cx.spawn(async move |this, cx| { let task: Task<Result<(), Error>> = cx.spawn(async move |this, cx| {
// The PR references the root patch event. // The PR references the root patch,
// Viewers can then find the patch without carrying it inline. // viewers can then find the patch without carrying it inline.
let root_patch = match publish_patch_series( let root_patch = match publish_patch_series(
&this, &client,
cx, &signer,
&addr, &addr,
owner, owner,
euc.as_deref(), euc.as_deref(),
@@ -814,11 +804,14 @@ impl RepoStore {
// Resolve the servers from the author's latest kind-10317 grasp list. // Resolve the servers from the author's latest kind-10317 grasp list.
// The settings defaults stand in when no list is published or the query fails. // The settings defaults stand in when no list is published or the query fails.
let author_servers = { let author_servers = {
let query = this.update(cx, |_this, cx| { let query_client = client.clone();
let client = Backend::global(cx).read(cx).client(); let published = cx
user_grasp_list_servers(client, user) .background_spawn(
})?; async move { user_grasp_list_servers(&query_client, user).await },
match cx.background_spawn(query).await { )
.await;
match published {
Ok(published) if !published.is_empty() => published, Ok(published) if !published.is_empty() => published,
_ => defaults, _ => defaults,
} }
@@ -852,24 +845,17 @@ impl RepoStore {
}; };
let builder = this.update(cx, |this, _cx| { let builder = this.update(cx, |this, _cx| {
// NIP-34 PRs carry at least one clone URL.
// The tip commit is downloadable from it.
// The author's `/prs/` URLs come first.
// They are author-controlled and most likely alive.
// The announced mirrors follow.
// The list is fixed before signing.
// The pushed ref name embeds the event id.
// Every candidate URL is listed up front.
// Dead URLs are inert, the linked patch stays the source of truth.
let prs_urls: Vec<Url> = author_targets let prs_urls: Vec<Url> = author_targets
.iter() .iter()
.filter_map(|(url, _)| Url::parse(url).ok()) .filter_map(|(url, _)| Url::parse(url).ok())
.collect(); .collect();
let base_clone = this let base_clone = this
.announcement .announcement
.as_ref() .as_ref()
.map(|a| a.clone.clone()) .map(|a| a.clone.clone())
.unwrap_or_default(); .unwrap_or_default();
let clone = pr_clone_urls(prs_urls, base_clone); let clone = pr_clone_urls(prs_urls, base_clone);
let builder = GitPullRequest { let builder = GitPullRequest {
@@ -894,8 +880,6 @@ impl RepoStore {
})?; })?;
// Sign before publishing. // Sign before publishing.
// The tip is pushed to the grasp servers under `refs/nostr/<event-id>`.
// Nak's convention, readers fetch that ref for the commit behind the `c` tag.
let event = cx let event = cx
.background_spawn({ .background_spawn({
let signer = signer.clone(); let signer = signer.clone();
@@ -906,20 +890,22 @@ impl RepoStore {
if let Some(path) = push_from.as_ref() { if let Some(path) = push_from.as_ref() {
let tip = current_commit.to_string(); let tip = current_commit.to_string();
let reference = format!("refs/nostr/{}", event.id.to_hex()); let reference = format!("refs/nostr/{}", event.id.to_hex());
let (pushed, failures) = cx let (pushed, failures) = cx
.background_spawn({ .background_spawn({
let path = path.clone(); let path = path.clone();
let tip = tip.clone(); let tip = tip.clone();
let reference = reference.clone(); let reference = reference.clone();
// Author servers first, then the announced base grasp servers. // Author servers first, then the announced base grasp servers.
// The extra targets are best-effort redundancy.
let targets: Vec<(String, String)> = author_targets let targets: Vec<(String, String)> = author_targets
.into_iter() .into_iter()
.chain(base_targets) .chain(base_targets)
.collect(); .collect();
async move { async move {
let mut failures = Vec::new(); let mut failures = Vec::new();
let mut pushed = 0; let mut pushed = 0;
for (url, label) in &targets { for (url, label) in &targets {
match signed_git::push_commit_ref( match signed_git::push_commit_ref(
&path, url, &tip, &reference, &path, url, &tip, &reference,
@@ -928,6 +914,7 @@ impl RepoStore {
Err(e) => failures.push(format!("{label}: {e}")), Err(e) => failures.push(format!("{label}: {e}")),
} }
} }
(pushed, failures) (pushed, failures)
} }
}) })
@@ -944,8 +931,6 @@ impl RepoStore {
} }
} }
let client = this.update(cx, |_this, cx| Backend::global(cx).read(cx).client())?;
let publish_result: Result<Event, Error> = async { let publish_result: Result<Event, Error> = async {
let output = client.send_event(&event).broadcast().await?; let output = client.send_event(&event).broadcast().await?;
require_relay_accepted(output, event) require_relay_accepted(output, event)
@@ -971,8 +956,8 @@ impl RepoStore {
} }
Ok(()) Ok(())
}) });
.detach(); self.tasks.push(task);
} }
/// Generate the patch between `merge_base` and `compare_ref` in `repo_path`, /// Generate the patch between `merge_base` and `compare_ref` in `repo_path`,
@@ -1036,8 +1021,12 @@ impl RepoStore {
self.last_warning = None; self.last_warning = None;
let backend = Backend::global(cx); let backend = Backend::global(cx);
let (user, client, signer) = {
let backend = backend.read(cx);
(backend.current_user(), backend.client(), backend.signer())
};
let Some(user) = backend.read(cx).current_user() else { let Some(user) = user else {
self.last_error = Some("Sign in to update the pull request".into()); self.last_error = Some("Sign in to update the pull request".into());
cx.notify(); cx.notify();
return; return;
@@ -1091,19 +1080,21 @@ impl RepoStore {
self.not_announced(cx); self.not_announced(cx);
return; return;
}; };
let owner = addr.public_key; let owner = addr.public_key;
let euc = self.announcement.as_ref().and_then(|a| a.euc.clone()); let euc = self.announcement.as_ref().and_then(|a| a.euc.clone());
let root = root.clone(); let root = root.clone();
let clone: Vec<Url> = self let clone: Vec<Url> = self
.announcement .announcement
.as_ref() .as_ref()
.map(|a| a.clone.clone()) .map(|a| a.clone.clone())
.unwrap_or_default(); .unwrap_or_default();
cx.spawn(async move |this, cx| { let task: Task<Result<(), Error>> = cx.spawn(async move |this, cx| {
if let Err(e) = publish_patch_series( if let Err(e) = publish_patch_series(
&this, &client,
cx, &signer,
&addr, &addr,
owner, owner,
euc.as_deref(), euc.as_deref(),
@@ -1119,7 +1110,7 @@ impl RepoStore {
}); });
} }
let builder = this.update(cx, |_this, _cx| { let builder = {
let builder = GitPullRequestUpdate { let builder = GitPullRequestUpdate {
repository: addr.clone(), repository: addr.clone(),
pull_request_event: root.id, pull_request_event: root.id,
@@ -1136,13 +1127,7 @@ impl RepoStore {
Some(euc) => builder.tag(Tag::parse(["r", euc]).expect("valid r tag")), Some(euc) => builder.tag(Tag::parse(["r", euc]).expect("valid r tag")),
None => builder, None => builder,
} }
})?; };
let (client, signer) = this.update(cx, |_this, cx| {
let backend = Backend::global(cx);
let backend = backend.read(cx);
(backend.client(), backend.signer())
})?;
let publish_result: Result<Event, Error> = async { let publish_result: Result<Event, Error> = async {
let event = builder.finalize_async(&signer).await?; let event = builder.finalize_async(&signer).await?;
@@ -1159,8 +1144,8 @@ impl RepoStore {
} }
Ok(()) Ok(())
}) });
.detach(); self.tasks.push(task);
} }
/// Set the status of a root event. /// Set the status of a root event.
@@ -1286,7 +1271,7 @@ impl RepoStore {
} }
Ok(()) Ok(())
}); });
task.detach(); self.tasks.push(task);
} }
/// The latest announcement of this repository, /// The latest announcement of this repository,
@@ -1602,7 +1587,7 @@ impl RepoStore {
Ok(()) Ok(())
}); });
task.detach(); self.tasks.push(task);
} }
} }
@@ -1672,8 +1657,8 @@ fn patch_current_commit(patch: &str) -> Option<&str> {
/// Returns the root event, the one a PR references. /// Returns the root event, the one a PR references.
#[allow(clippy::too_many_arguments)] #[allow(clippy::too_many_arguments)]
async fn publish_patch_series( async fn publish_patch_series(
this: &WeakEntity<RepoStore>, client: &Client,
cx: &mut AsyncApp, signer: &UniversalSigner,
addr: &RepoAddr, addr: &RepoAddr,
owner: PublicKey, owner: PublicKey,
euc: Option<&str>, euc: Option<&str>,
@@ -1681,12 +1666,6 @@ async fn publish_patch_series(
first_marker: &str, first_marker: &str,
reply_to: Option<EventId>, reply_to: Option<EventId>,
) -> Result<Event, Error> { ) -> Result<Event, Error> {
let (client, signer) = this.update(cx, |_this, cx| {
let backend = Backend::global(cx);
let backend = backend.read(cx);
(backend.client(), backend.signer())
})?;
let mut root: Option<Event> = None; let mut root: Option<Event> = None;
let mut previous = reply_to; let mut previous = reply_to;
@@ -1699,6 +1678,7 @@ async fn publish_patch_series(
}; };
let mut tags = vec![Tag::coordinate(addr.clone(), None), Tag::public_key(owner)]; let mut tags = vec![Tag::coordinate(addr.clone(), None), Tag::public_key(owner)];
if ix == 0 { if ix == 0 {
if let Ok(tag) = Tag::parse(["t", first_marker]) { if let Ok(tag) = Tag::parse(["t", first_marker]) {
tags.push(tag); tags.push(tag);
@@ -1713,21 +1693,23 @@ async fn publish_patch_series(
{ {
tags.push(tag); tags.push(tag);
} }
if let Some(euc) = euc if let Some(euc) = euc
&& let Ok(tag) = Tag::parse(["r", euc]) && let Ok(tag) = Tag::parse(["r", euc])
{ {
tags.push(tag); tags.push(tag);
} }
if let Ok(tag) = Tag::parse(["commit", commit]) { if let Ok(tag) = Tag::parse(["commit", commit]) {
tags.push(tag); tags.push(tag);
} }
if let Ok(tag) = Tag::parse(["r", commit]) { if let Ok(tag) = Tag::parse(["r", commit]) {
tags.push(tag); tags.push(tag);
} }
let builder = EventBuilder::new(Kind::GitPatch, part.clone()).tags(tags); let builder = EventBuilder::new(Kind::GitPatch, part.clone()).tags(tags);
let event = builder.finalize_async(signer).await?;
let event = builder.finalize_async(&signer).await?;
let output = client.send_event(&event).broadcast().await?; let output = client.send_event(&event).broadcast().await?;
let event = require_relay_accepted(output, event)?; let event = require_relay_accepted(output, event)?;
@@ -303,6 +303,7 @@ pub struct CommitDiffView {
loading: bool, loading: bool,
error: Option<SharedString>, error: Option<SharedString>,
pane: Entity<DiffPane>, pane: Entity<DiffPane>,
tasks: Vec<gpui::Task<Result<(), anyhow::Error>>>,
} }
impl CommitDiffView { impl CommitDiffView {
@@ -336,6 +337,7 @@ impl CommitDiffView {
loading: true, loading: true,
error: None, error: None,
pane, pane,
tasks: Vec::new(),
} }
} }
@@ -383,7 +385,7 @@ impl CommitDiffView {
Ok(()) Ok(())
}); });
task.detach(); self.tasks.push(task);
} }
fn render_header(&self, cx: &mut Context<Self>) -> AnyElement { fn render_header(&self, cx: &mut Context<Self>) -> AnyElement {
+6 -2
View File
@@ -187,12 +187,16 @@ impl InboxView {
self.refresh.begin(); self.refresh.begin();
let backend = Backend::global(cx); let backend = Backend::global(cx);
let Some(me) = backend.read(cx).current_user() else { let (me, client) = {
let backend = backend.read(cx);
(backend.current_user(), backend.client())
};
let Some(me) = me else {
self.refresh.abort(); self.refresh.abort();
return; return;
}; };
let client = backend.read(cx).client();
let state = self.state.clone(); let state = self.state.clone();
let work = cx.background_spawn(async move { query_inbox(&client, me, &state).await }); let work = cx.background_spawn(async move { query_inbox(&client, me, &state).await });
@@ -79,8 +79,7 @@ pub struct PullRequestDetailView {
pane: Entity<DiffPane>, pane: Entity<DiffPane>,
commit_item_sizes: Rc<Vec<Size<Pixels>>>, commit_item_sizes: Rc<Vec<Size<Pixels>>>,
commit_scroll_handle: VirtualListScrollHandle, commit_scroll_handle: VirtualListScrollHandle,
/// The dock caches item panels, so without this observer a panel opened tasks: Vec<gpui::Task<Result<(), anyhow::Error>>>,
/// before the store loaded would stay on its placeholder.
_subscription: Subscription, _subscription: Subscription,
} }
@@ -124,6 +123,7 @@ impl PullRequestDetailView {
pane, pane,
commit_item_sizes: Rc::new(Vec::new()), commit_item_sizes: Rc::new(Vec::new()),
commit_scroll_handle: VirtualListScrollHandle::new(), commit_scroll_handle: VirtualListScrollHandle::new(),
tasks: Vec::new(),
_subscription: subscription, _subscription: subscription,
} }
} }
@@ -327,7 +327,7 @@ impl PullRequestDetailView {
Ok(()) Ok(())
}); });
task.detach(); self.tasks.push(task);
} }
/// Open the diff of `commit_id` in the bottom dock of the area. /// Open the diff of `commit_id` in the bottom dock of the area.
@@ -68,6 +68,7 @@ pub struct NewPullRequestView {
pane: Entity<DiffPane>, pane: Entity<DiffPane>,
scroll_handle: VirtualListScrollHandle, scroll_handle: VirtualListScrollHandle,
item_sizes: Rc<Vec<Size<Pixels>>>, item_sizes: Rc<Vec<Size<Pixels>>>,
tasks: Vec<gpui::Task<Result<(), anyhow::Error>>>,
_subscriptions: Vec<Subscription>, _subscriptions: Vec<Subscription>,
} }
@@ -323,6 +324,7 @@ impl NewPullRequestView {
pane, pane,
scroll_handle: VirtualListScrollHandle::new(), scroll_handle: VirtualListScrollHandle::new(),
item_sizes: Rc::new(Vec::new()), item_sizes: Rc::new(Vec::new()),
tasks: Vec::new(),
_subscriptions: subscriptions, _subscriptions: subscriptions,
} }
} }
@@ -390,7 +392,8 @@ impl NewPullRequestView {
Ok(()) Ok(())
}); });
task.detach();
self.tasks.push(task);
} }
/// Branches and the current branch are read off the UI thread, then applied. /// Branches and the current branch are read off the UI thread, then applied.
@@ -419,7 +422,8 @@ impl NewPullRequestView {
Ok(()) Ok(())
}); });
task.detach();
self.tasks.push(task);
} }
fn apply_checkout( fn apply_checkout(
@@ -636,7 +640,8 @@ impl NewPullRequestView {
Ok(()) Ok(())
}); });
task.detach();
self.tasks.push(task);
} }
#[allow(clippy::too_many_arguments)] #[allow(clippy::too_many_arguments)]
@@ -830,7 +835,7 @@ impl NewPullRequestView {
Ok(()) Ok(())
}); });
task.detach(); self.tasks.push(task);
} }
fn submit(&mut self, window: &mut Window, cx: &mut Context<Self>) { fn submit(&mut self, window: &mut Window, cx: &mut Context<Self>) {
@@ -911,7 +916,7 @@ impl NewPullRequestView {
Ok(()) Ok(())
}); });
task.detach(); self.tasks.push(task);
} }
fn open_commit_diff(&mut self, commit_id: &str, window: &mut Window, cx: &mut Context<Self>) { fn open_commit_diff(&mut self, commit_id: &str, window: &mut Window, cx: &mut Context<Self>) {
@@ -215,15 +215,19 @@ pub fn load_user_grasp_servers(
cx: &mut App, cx: &mut App,
) { ) {
let backend = Backend::global(cx); let backend = Backend::global(cx);
let Some(user) = backend.read(cx).current_user() else { let (user, client) = {
let backend = backend.read(cx);
(backend.current_user(), backend.client())
};
let Some(user) = user else {
state.update(cx, |state, _| state.loading_servers = false); state.update(cx, |state, _| state.loading_servers = false);
return; return;
}; };
let client = backend.read(cx).client();
let handle = window.window_handle(); let handle = window.window_handle();
cx.spawn(async move |cx| { cx.spawn(async move |cx| {
let result = signed_state::user_grasp_list_servers(client, user).await; let result = signed_state::user_grasp_list_servers(&client, user).await;
let _ = cx.update_window(handle, |_, _window, cx| { let _ = cx.update_window(handle, |_, _window, cx| {
state.update(cx, |state, _| { state.update(cx, |state, _| {
+1 -1
View File
@@ -14,7 +14,7 @@ product-name = "Signed"
description = "Nostr Git client for browsing repositories and collaborating" description = "Nostr Git client for browsing repositories and collaborating"
identifier = "info.reya.signed" identifier = "info.reya.signed"
category = "DeveloperTool" category = "DeveloperTool"
version = "0.1.0-alpha" version = "0.2.0-alpha"
out-dir = "../dist" out-dir = "../dist"
before-packaging-command = "cargo build --release" before-packaging-command = "cargo build --release"
resources = ["Cargo.toml", "src"] resources = ["Cargo.toml", "src"]